[PATCH 2/2] audit: add "on"/"off" as valid boot parameter values

2018-02-23 Thread Greg Edwards
Modify the "audit" boot parameter to also accept "on" or "off" as valid parameter values. Update the documentation accordingly. Signed-off-by: Greg Edwards --- Documentation/admin-guide/kernel-parameters.txt | 14 +++--- kernel/audit.c | 9 + 2

[PATCH 1/2] audit: move processing of "audit" boot param to audit_init()

2018-02-23 Thread Greg Edwards
The processing of the "audit" boot parameter is handled before the console has been initialized. We therefore miss any panic messages if we fail to verify the boot parameter or set the audit state, unless we also enable earlyprintk. Instead, have the boot parameter function just save the paramete

[PATCH 0/2] audit boot parameter cleanups

2018-02-23 Thread Greg Edwards
One of our CI tests was booting upstream kernels with the "audit=off" kernel parameter. This was our error; it should have been "audit=0". However, in 4.15 the verification of the boot parameter got more strict in 80ab4df62706 ("audit: don't use simple_strtol() anymore"), and our errant boot para

Re: [PATCH 0/2] audit boot parameter cleanups

2018-02-23 Thread Richard Guy Briggs
On 2018-02-22 17:22, Greg Edwards wrote: > One of our CI tests was booting upstream kernels with the "audit=off" kernel > parameter. This was our error; it should have been "audit=0". However, > in 4.15 the verification of the boot parameter got more strict in 80ab4df62706 > ("audit: don't use si

Re: [PATCH] audit: track the owner of the command mutex ourselves

2018-02-23 Thread Paul Moore
On Thu, Feb 22, 2018 at 3:40 AM, Richard Guy Briggs wrote: > On 2018-02-20 11:55, Paul Moore wrote: >> From: Paul Moore >> >> Evidently the __mutex_owner() function was never intended for use >> outside the core mutex code, so build a thing locking wrapper around >> the mutex code which allows us

Re: [PATCH 0/2] audit boot parameter cleanups

2018-02-23 Thread Paul Moore
On Fri, Feb 23, 2018 at 11:07 AM, Richard Guy Briggs wrote: > On 2018-02-22 17:22, Greg Edwards wrote: >> One of our CI tests was booting upstream kernels with the "audit=off" kernel >> parameter. This was our error; it should have been "audit=0". However, >> in 4.15 the verification of the boot