Re: [PATCH] audit: remove the audit freelist

2016-12-02 Thread Paul Moore
On Thu, Dec 1, 2016 at 7:09 PM, Florian Westphal wrote: > Paul Moore wrote: >> On Wed, Nov 30, 2016 at 8:44 PM, Florian Westphal wrote: >> > Paul Moore wrote: >> >> On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: >> >> > allows better debugging as freeing audit buffers now always hono

Re: [PATCH] audit: remove the audit freelist

2016-12-01 Thread Florian Westphal
Paul Moore wrote: > On Wed, Nov 30, 2016 at 8:44 PM, Florian Westphal wrote: > > Paul Moore wrote: > >> On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: > >> > allows better debugging as freeing audit buffers now always honors slub > >> > debug hooks (e.g. object poisoning) and leak che

Re: [PATCH] audit: remove the audit freelist

2016-12-01 Thread Paul Moore
On Wed, Nov 30, 2016 at 8:44 PM, Florian Westphal wrote: > Paul Moore wrote: >> On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: >> > allows better debugging as freeing audit buffers now always honors slub >> > debug hooks (e.g. object poisoning) and leak checker can detect the >> > free

Re: [PATCH] audit: remove the audit freelist

2016-12-01 Thread Florian Westphal
Paul Moore wrote: > On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: > > allows better debugging as freeing audit buffers now always honors slub > > debug hooks (e.g. object poisoning) and leak checker can detect the > > free operation. > > > > Removal also results in a small speedup (usi

Re: [PATCH] audit: remove the audit freelist

2016-11-30 Thread William Roberts
On Nov 29, 2016 07:10, "Florian Westphal" wrote: > > allows better debugging as freeing audit buffers now always honors slub > debug hooks (e.g. object poisoning) and leak checker can detect the > free operation. > > Removal also results in a small speedup (using > single rule 'iptables -A INPUT -

Re: [PATCH] audit: remove the audit freelist

2016-11-30 Thread Paul Moore
On Tue, Nov 15, 2016 at 8:16 AM, Florian Westphal wrote: > allows better debugging as freeing audit buffers now always honors slub > debug hooks (e.g. object poisoning) and leak checker can detect the > free operation. > > Removal also results in a small speedup (using > single rule 'iptables -A I

Re: [PATCH] audit: remove the audit freelist

2016-11-29 Thread Richard Guy Briggs
On 2016-11-29 18:24, Florian Westphal wrote: > Richard Guy Briggs wrote: > > > static void audit_buffer_free(struct audit_buffer *ab) > > > { > > > - unsigned long flags; > > > - > > > if (!ab) > > > return; > > > > > > kfree_skb(ab->skb); > > > - spin_lock_irqsave(&audit_freelis

Re: [PATCH] audit: remove the audit freelist

2016-11-29 Thread Florian Westphal
Richard Guy Briggs wrote: > > static void audit_buffer_free(struct audit_buffer *ab) > > { > > - unsigned long flags; > > - > > if (!ab) > > return; > > > > kfree_skb(ab->skb); > > - spin_lock_irqsave(&audit_freelist_lock, flags); > > - if (audit_freelist_count > AUDI

Re: [PATCH] audit: remove the audit freelist

2016-11-29 Thread Richard Guy Briggs
On 2016-11-15 14:16, Florian Westphal wrote: > allows better debugging as freeing audit buffers now always honors slub > debug hooks (e.g. object poisoning) and leak checker can detect the > free operation. > > Removal also results in a small speedup (using > single rule 'iptables -A INPUT -i lo -