Re: [PATCH v2] statx: stx_subvol

2024-05-28 Thread Andreas Dilger
> On May 28, 2024, at 6:46 AM, John Garry wrote: > > On 12/03/2024 02:13, Eric Biggers wrote: >> On Thu, Mar 07, 2024 at 09:29:12PM -0500, Kent Overstreet wrote: >>> __u32 stx_dio_mem_align; /* Memory buffer alignment for direct >>> I/O */ >>> __u32 stx_dio_offset_align; /* F

Re: [PATCH v3 01/13] fs: fiemap: add physical_length field to extents

2024-04-09 Thread Andreas Dilger
On Apr 9, 2024, at 10:22 AM, Darrick J. Wong wrote: > > On Wed, Apr 03, 2024 at 03:22:42AM -0400, Sweet Tea Dorminy wrote: >> Some filesystems support compressed extents which have a larger logical >> size than physical, and for those filesystems, it can be useful for >> userspace to know how muc

Re: [PATCH v3 13/13] bcachefs: fiemap: emit new COMPRESSED state

2024-04-05 Thread Andreas Dilger
> On Apr 5, 2024, at 1:17 PM, Andreas Dilger wrote: > > On Apr 3, 2024, at 1:22 AM, Sweet Tea Dorminy > wrote: >> >> Signed-off-by: Sweet Tea Dorminy >> --- >> fs/bcachefs/fs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >

Re: [PATCH v3 08/13] f2fs: fiemap: add physical length to trace_f2fs_fiemap

2024-04-05 Thread Andreas Dilger
On Apr 3, 2024, at 1:22 AM, Sweet Tea Dorminy wrote: > > Signed-off-by: Sweet Tea Dorminy With the compat macro in the first patch in the series, IMHO this one should be merged into the next patch that actually sets the phys_len, since passing "0" for the phys_len isn't super useful by itself

Re: [PATCH v3 06/13] nilfs2: fiemap: return correct extent physical length

2024-04-05 Thread Andreas Dilger
On Apr 3, 2024, at 1:22 AM, Sweet Tea Dorminy wrote: > > Signed-off-by: Sweet Tea Dorminy > --- > fs/nilfs2/inode.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c > index 4d3c347c982b..e3108f2cead7 100644 > --- a/fs/ni

Re: [PATCH v3 13/13] bcachefs: fiemap: emit new COMPRESSED state

2024-04-05 Thread Andreas Dilger
On Apr 3, 2024, at 1:22 AM, Sweet Tea Dorminy wrote: > > Signed-off-by: Sweet Tea Dorminy > --- > fs/bcachefs/fs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c > index d2793bae842d..54f613f977b4 100644 > --- a/fs/bcachefs/fs.c > ++

Re: [PATCH v3 04/13] btrfs: fiemap: emit new COMPRESSED state.

2024-04-05 Thread Andreas Dilger
On Apr 3, 2024, at 1:22 AM, Sweet Tea Dorminy wrote: > > Signed-off-by: Sweet Tea Dorminy I would recommend to merge this with the 05/13 patch that is setting the btrfs fe_physical_length field. Otherwise, by itself it would be confusing that the DATA_COMPRESSED flag is set on the extent with

Re: [PATCH v3 03/13] fiemap: add new COMPRESSED extent state

2024-04-05 Thread Andreas Dilger
ks good. Reviewed-by: Andreas Dilger > --- > Documentation/filesystems/fiemap.rst | 4 > fs/ioctl.c | 3 ++- > include/uapi/linux/fiemap.h | 2 ++ > 3 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/fi

Re: [PATCH v3 02/13] fiemap: update fiemap_fill_next_extent() signature

2024-04-05 Thread Andreas Dilger
On Apr 3, 2024, at 1:22 AM, Sweet Tea Dorminy wrote: > > Update the signature of fiemap_fill_next_extent() to allow passing a > physical length. Update all callers to pass a 0 physical length -- since > none set the EXTENT_HAS_PHYS_LEN flag, this value doesn't matter. Patch-structure-wise, it d

Re: [PATCH v3 01/13] fiemap: add physical_length field to extents

2024-04-05 Thread Andreas Dilger
On Apr 3, 2024, at 1:22 AM, Sweet Tea Dorminy wrote: > > Some filesystems support compressed extents which have a larger logical > size than physical, and for those filesystems, it can be useful for > userspace to know how much space those extents actually use. For > instance, the compsize [1] t

Re: [PATCH v3 00/13] fiemap extension for more physical information

2024-04-05 Thread Andreas Dilger
On Apr 3, 2024, at 12:17 PM, Kent Overstreet wrote: > > On Wed, Apr 03, 2024 at 03:22:41AM -0400, Sweet Tea Dorminy wrote: >> For many years, various btrfs users have written programs to discover >> the actual disk space used by files, using root-only interfaces. >> However, this information is a

Re: file handle in statx (was: Re: How to cope with subvolumes and snapshots on muti-user systems?)

2023-12-13 Thread Andreas Dilger
On Dec 12, 2023, at 5:02 PM, NeilBrown wrote: > > On Wed, 13 Dec 2023, Kent Overstreet wrote: >> On Wed, Dec 13, 2023 at 09:57:22AM +1100, NeilBrown wrote: >>> On Wed, 13 Dec 2023, Kent Overstreet wrote: On Mon, Dec 11, 2023 at 11:40:16PM +, David Howells wrote: > Kent Overstreet wr