On 09/09/2016 05:00 PM, Josef Bacik wrote:
Right. Alternatively, you could perhaps make it so that the lost
connection is removed, unack'd requests on that connection are resent,
and the session moves on with one less connection (unless the lost
connection is the last one, in which case we die as
On 09/09/2016 04:55 PM, Wouter Verhelst wrote:
On Fri, Sep 09, 2016 at 04:36:07PM -0400, Josef Bacik wrote:
On 09/09/2016 04:02 PM, Wouter Verhelst wrote:
[...]
I see some practical problems with this:
- You removed the pid attribute from sysfs (unless you added it back and
I didn't notice,
On Fri, Sep 09, 2016 at 04:36:07PM -0400, Josef Bacik wrote:
> On 09/09/2016 04:02 PM, Wouter Verhelst wrote:
[...]
> > I see some practical problems with this:
> > - You removed the pid attribute from sysfs (unless you added it back and
> > I didn't notice, in which case just ignore this part).
On 09/09/2016 04:02 PM, Wouter Verhelst wrote:
Hi Josef,
On Thu, Sep 08, 2016 at 05:12:05PM -0400, Josef Bacik wrote:
Apologies if you are getting this a second time, it appears vger ate my last
submission.
--
This is a patch
On 09/09/2016 02:08 PM, Wouter Verhelst wrote:
Hi Jens,
On Thu, Sep 08, 2016 at 02:13:46PM -0600, Jens Axboe wrote:
Not only are these nice performance improvements, it also cleans up the
code a lot and kills crufty old driver code in favor of using the proper
APIs instead. I have applied the s
On 09/09/2016 02:02 PM, Jens Axboe wrote:
On 09/09/2016 01:00 PM, Ritesh Raj Sarraf wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Hi Jens,
[Please CC me in replies. I'm not subscribed to the list]
Based on your announcement about the writeback patches, I have picked
up your
changes f
Hi Josef,
On Thu, Sep 08, 2016 at 05:12:05PM -0400, Josef Bacik wrote:
> Apologies if you are getting this a second time, it appears vger ate my last
> submission.
>
> --
>
> This is a patch series aimed at bringing NBD into 201
Hi Jens,
On Thu, Sep 08, 2016 at 02:13:46PM -0600, Jens Axboe wrote:
> Not only are these nice performance improvements, it also cleans up the
> code a lot and kills crufty old driver code in favor of using the proper
> APIs instead. I have applied the series for 4.9.
Please ensure that the comme
On 09/09/2016 01:00 PM, Ritesh Raj Sarraf wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Hi Jens,
[Please CC me in replies. I'm not subscribed to the list]
Based on your announcement about the writeback patches, I have picked up your
changes for testing.
I tested it on a 4.7.3 stable
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Hi Jens,
[Please CC me in replies. I'm not subscribed to the list]
Based on your announcement about the writeback patches, I have picked up your
changes for testing.
I tested it on a 4.7.3 stable kernel with patches applied from your axboe/wb-
buf
From: Omar Sandoval
Again, there's no point in passing this in every time. Make it part of
struct sbitmap_queue and clean up the API.
Signed-off-by: Omar Sandoval
---
block/blk-mq-tag.c | 33 +++--
block/blk-mq-tag.h | 1 -
include/linux/sbitmap.h | 22 ++
From: Omar Sandoval
This is a generally useful data structure, so make it available to
anyone else who might want to use it. It's also a nice cleanup
separating the allocation logic from the rest of the tag handling logic.
The code is behind a new Kconfig option, CONFIG_SBITMAP, which is only
se
From: Omar Sandoval
This is v3 of the scalable bitmap library derived from blk-mq's tag
allocation code. v1 is here [1], v2 is here [2].
Changes in v3:
- Renamed scale_bitmap to sbitmap
Changes in v2:
- Return -EINVAL instead of BUG_ON() if an invalid shift is passed to
the initialization f
From: Omar Sandoval
In order to get good cache behavior from a sbitmap, we want each CPU to
stick to its own cacheline(s) as much as possible. This might happen
naturally as the bitmap gets filled up and the last_cache values spread
out, but we really want this behavior from the start. blk-mq app
From: Omar Sandoval
The original bt_alloc() we converted from was using kzalloc(), not
kzalloc_node(), to allocate the wait queues. This was probably an
oversight, so fix it for sbitmap_queue_init_node().
Signed-off-by: Omar Sandoval
---
lib/sbitmap.c | 2 +-
1 file changed, 1 insertion(+), 1
From: Omar Sandoval
Allocating your own per-cpu allocation hint separately makes for an
awkward API. Instead, allocate the per-cpu hint as part of the struct
sbitmap_queue. There's no point for a struct sbitmap_queue without the
cache, but you can still use a bare struct sbitmap.
Signed-off-by:
On Fri, Sep 09, 2016 at 08:03:42PM +0200, Stefan Priebe - Profihost AG wrote:
> Am 08.09.2016 um 19:33 schrieb Shaohua Li:
> > On Thu, Sep 08, 2016 at 10:16:59AM -0600, Jens Axboe wrote:
> >> On 09/08/2016 02:23 AM, Stefan Priebe - Profihost AG wrote:
> >>> Hi,
> >>>
> >>> while trying Kernel 4.8-r
Am 08.09.2016 um 19:33 schrieb Shaohua Li:
> On Thu, Sep 08, 2016 at 10:16:59AM -0600, Jens Axboe wrote:
>> On 09/08/2016 02:23 AM, Stefan Priebe - Profihost AG wrote:
>>> Hi,
>>>
>>> while trying Kernel 4.8-rc5 my raid5 breaks every few minutes.
>>>
>>> Trace:
>>> [ cut here ]-
On 09/09/2016 10:15 AM, Joe Perches wrote:
On Fri, 2016-09-09 at 10:11 -0600, Jens Axboe wrote:
The variable is called 'runtime_flags' - if that doesn't already tell
the reader how it's used, then I'd suggest the reader go read something
else.
I'm all for using established APIs where it makes s
On Fri, 2016-09-09 at 10:11 -0600, Jens Axboe wrote:
> The variable is called 'runtime_flags' - if that doesn't already tell
> the reader how it's used, then I'd suggest the reader go read something
> else.
>
> I'm all for using established APIs where it makes sense. Declaring a
> bitmap for a few
On 09/09/2016 10:04 AM, Joe Perches wrote:
On Fri, 2016-09-09 at 07:55 -0600, Jens Axboe wrote:
On 09/08/2016 07:20 PM, Joe Perches wrote:
On Thu, 2016-09-08 at 17:12 -0400, Josef Bacik wrote:
In preparation for some future changes, change a few of the state bools over to
normal bits to set/cl
On Fri, 2016-09-09 at 07:55 -0600, Jens Axboe wrote:
> On 09/08/2016 07:20 PM, Joe Perches wrote:
> > On Thu, 2016-09-08 at 17:12 -0400, Josef Bacik wrote:
> > > In preparation for some future changes, change a few of the state bools
> > > over to
> > > normal bits to set/clear properly.
> > []
>
On 09/08/2016 07:20 PM, Joe Perches wrote:
On Thu, 2016-09-08 at 17:12 -0400, Josef Bacik wrote:
In preparation for some future changes, change a few of the state bools over to
normal bits to set/clear properly.
[]
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
[]
@@ -41,8 +41,12 @@
Il giorno 07/set/2016, alle ore 16:46, Jens Axboe ha scritto:
> Hi,
>
Hi Jens,
I have tested your patchset a little bit on some HDDs and SSDs, by
measuring the start-up time, with cfq and cold caches, of
gnome-terminal, while one sequential reader and one sequential writer
are running in paral
24 matches
Mail list logo
