Re: [PATCH V4 09/15] blk-throttle: make bandwidth change smooth

On Wed, Nov 23, 2016 at 04:23:35PM -0500, Tejun Heo wrote: > Hello, > > On Mon, Nov 14, 2016 at 02:22:16PM -0800, Shaohua Li wrote: > > cg1/cg2 bps: 10/80 -> 15/105 -> 20/100 -> 25/95 -> 30/90 -> 35/85 -> 40/80 > > -> 45/75 -> 10/80 > > I wonder whether it'd make sense to make the clamping down

Re: [PATCH V4 10/15] blk-throttle: add a simple idle detection

Hello, Shaohua. On Mon, Nov 14, 2016 at 02:22:17PM -0800, Shaohua Li wrote: > Unfortunately it's very hard to determine if a cgroup is real idle. This > patch uses the 'think time check' idea from CFQ for the purpose. Please > note, the idea doesn't work for all workloads. For example, a workload

Re: [PATCH V4 11/15] blk-throttle: add interface to configure think time threshold

On Mon, Nov 14, 2016 at 02:22:18PM -0800, Shaohua Li wrote: > Add interface to configure the threshold > > Signed-off-by: Shaohua Li > --- > block/blk-sysfs.c| 7 +++ > block/blk-throttle.c | 25 + > block/blk.h | 4 > 3 files

Re: [PATCH V4 07/15] blk-throttle: make throtl_slice tunable

Hello, On Tue, Nov 22, 2016 at 03:18:24PM -0800, Shaohua Li wrote: > Hmm, it's not a real 'time slice'. The name is a bit confusion. Maybe rename > it > to 'throtl_interval' or 'throtl_sampling_time'? not sure. bandwidth and iops > are always in terms of a time interval we measure them. We can't

Re: [PATCH 0/8] lightnvm: simplify media manager V2

> On 23 Nov 2016, at 13.06, Matias Bjørling wrote: > > On 11/21/2016 01:10 PM, Javier González wrote: >> V2: >> - Fix 2 bad memory free on error rrpc init error handling. Reported by >>kbuild. >> >> This patchset simplifies the generic media manager interface and moves >>