Re: [PATCH 5/6] blk-mq: Fix queue freeze deadlock

2017-01-04 Thread Bart Van Assche
On Wed, 2017-01-04 at 17:41 -0500, Keith Busch wrote: > +static void blk_mq_abandon_stopped_requests(struct request_queue *q) > +{ > + int i; > + struct request *rq, *next; > + struct blk_mq_hw_ctx *hctx; > + LIST_HEAD(rq_list); > + > + blk_mq_sync_queue(q); > + > +

[PATCH 6/6] blk-mq: Remove unused variable

2017-01-04 Thread Keith Busch
Signed-off-by: Keith Busch --- block/blk-mq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 0c9a2a3..fae9651 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -916,7 +916,6 @@ bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx

[PATCH 1/6] irq/affinity: Assign all online CPUs to vectors

2017-01-04 Thread Keith Busch
This patch makes sure all online CPUs are assigned to vectors in cases where the nodes don't have the same number of online CPUs. The calculation for how many vectors needs to be assigned should account for the number of CPUs for a particular node on each round of assignment in order to ensure all

[PATCH 3/6] nvme/pci: Start queues after tagset is updated

2017-01-04 Thread Keith Busch
We need to leave the block queues stopped if we're changing the tagset's number of queues. Signed-off-by: Keith Busch --- drivers/nvme/host/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index

[PATCH 2/6] irq/affinity: Assign offline CPUs a vector

2017-01-04 Thread Keith Busch
The offline CPUs need to assigned to something incase they come online later, otherwise anyone using the mapping for things other than affinity will have blank entries for that online CPU. Signed-off-by: Keith Busch --- kernel/irq/affinity.c | 8 1 file changed,

Re: [GIT PULL] minor floppy fix

2017-01-04 Thread Jens Axboe
On 01/04/2017 07:15 AM, Jiri Kosina wrote: > Jens, > > please pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/jikos/linux-block.git for-jens > > (based on your current for-next branch) > > to get minor memory allocation fix for floppy driver, from Vlastimil > Babka. Added for

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-04 Thread Mike Snitzer
On Wed, Jan 04 2017 at 12:12am -0500, NeilBrown wrote: > On Tue, Jan 03 2017, Jack Wang wrote: > > > 2016-12-23 12:45 GMT+01:00 Lars Ellenberg : > >> On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: > >>> Dear Maintainers > >>> > >>> I'd

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2017-01-04 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Jan Kara" > Cc: "Johannes Weiner" , "Hugh Dickins" > , "Linus Torvalds" > , "Dave Chinner" , "Chris >

Re: [LSF/MM TOPIC] blk-trace update vs API stability

2017-01-04 Thread Jeff Moyer
Hannes Reinecke writes: > At LSF I'd like to discuss > - Do we consider blktrace (and any other tracepoint in eg SCSI) as a > stable API? I don't have a strong opinion on this. > - How do we go about modifying blktrace? Blktrace has a version number associated with trace events.

Re: [LSF/MM TOPIC][LSF/MM ATTEND] OCSSDs - SMR, Hierarchical Interface, and Vector I/Os

2017-01-04 Thread Theodore Ts'o
I agree with Damien, but I'd also add that in the future there may very well be some new Zone types added to the ZBC model. So we shouldn't assume that the ZBC model is a fixed one. And who knows? Perhaps T10 standards body will come up with a simpler model for interfacing with

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2017-01-04 Thread Laurence Oberman
- Original Message - > From: "Jan Kara" > To: "Johannes Weiner" > Cc: "Hugh Dickins" , "Linus Torvalds" > , "Dave Chinner" > , "Chris Leech" , "Linux Kernel >

Re: [patch] block: fix up io_poll documentation

2017-01-04 Thread Jeff Moyer
Jens Axboe writes: > On 01/03/2017 03:51 PM, Jeff Moyer wrote: >> >> /sys/block//queue/io_poll is a boolean. Fix the docs. >> >> Signed-off-by: Jeff Moyer >> >> diff --git a/Documentation/block/queue-sysfs.txt >> b/Documentation/block/queue-sysfs.txt >>

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2017-01-04 Thread Christoph Hellwig
On Sat, Dec 24, 2016 at 02:17:26PM +0100, Hannes Reinecke wrote: > Christoph, do you have a pointer to your patchset? Here is a pointer to the current one after splitting it into properly bisectable chunks. Besides proper changelogs the biggest item left is fixing up dm-mpath to not allocate its

[GIT PULL] minor floppy fix

2017-01-04 Thread Jiri Kosina
Jens, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/jikos/linux-block.git for-jens (based on your current for-next branch) to get minor memory allocation fix for floppy driver, from Vlastimil Babka. Thanks.

Re: [PATCH PoCv2 0/2] mmc: add blk-mq support

2017-01-04 Thread Linus Walleij
On Tue, Jan 3, 2017 at 6:30 PM, Bartlomiej Zolnierkiewicz wrote: Interesting patch! > The differences between these patches and Linus' RFD patch: > - request completion is handled from the IRQ handler > (or tasklet context as happens in dw_mmc host driver) I think

[LSF/MM TOPIC] blk-trace update vs API stability

2017-01-04 Thread Hannes Reinecke
Hi all, during investigating performance issues I frequently have the need to include the request tag in the scsi tracepoints. While this can be easily done for scsi, including it in block trace output is not that easy due to the interdependency with the blktrace utilities. Also there had been