Re: [PATCH] scsi: zero per-cmd driver data before each I/O

On 02/20/2017 05:52 PM, Christoph Hellwig wrote: > Without this drivers that don't clear the state themselves can see off > effects. For example Hyper-V VMs using the storvsc driver will often > hang during boot due to uncleared Test Unit Ready failures. > > Fixes: e9c787e6 ("scsi: allocate

Re: [GIT PULL] Block pull request for- 4.11-rc1

On 02/20/2017 08:32 AM, Jens Axboe wrote: > Bart, since you are the only one that can reproduce this, can you just bisect > your way through that series? Hello Jens, I will do that as soon as I'm back in the office (later this week). Bart.

Re: [PATCH 0/5] block subsystem refcounter conversions

On Mon, 2017-02-20 at 17:56 +0100, Peter Zijlstra wrote: > On Mon, Feb 20, 2017 at 07:41:01AM -0800, James Bottomley wrote: > > On Mon, 2017-02-20 at 08:15 -0700, Jens Axboe wrote: > > > On 02/20/2017 04:16 AM, Elena Reshetova wrote: > > > > Now when new refcount_t type and API are finally merged

Re: [PATCH] scsi: zero per-cmd driver data before each I/O

On 02/20/2017 08:52 AM, Christoph Hellwig wrote: > Without this drivers that don't clear the state themselves can see off > effects. For example Hyper-V VMs using the storvsc driver will often > hang during boot due to uncleared Test Unit Ready failures. > > Fixes: e9c787e6 ("scsi: allocate

Re: [PATCH 08/10] block: Fix oops in locked_inode_to_wb_and_lock_list()

On Sun 12-02-17 13:40:27, Tejun Heo wrote: > Hello, Jan. > > On Thu, Feb 09, 2017 at 01:44:31PM +0100, Jan Kara wrote: > > When block device is closed, we call inode_detach_wb() in __blkdev_put() > > which sets inode->i_wb to NULL. That is contrary to expectations that > > inode->i_wb stays valid

[PATCH] scsi: zero per-cmd driver data before each I/O

Without this drivers that don't clear the state themselves can see off effects. For example Hyper-V VMs using the storvsc driver will often hang during boot due to uncleared Test Unit Ready failures. Fixes: e9c787e6 ("scsi: allocate scsi_cmnd structures as part of struct request")

Re: [GIT PULL] Block pull request for- 4.11-rc1

On 02/20/2017 09:16 AM, Bart Van Assche wrote: > On 02/19/2017 11:35 PM, Christoph Hellwig wrote: >> On Sun, Feb 19, 2017 at 06:15:41PM -0700, Jens Axboe wrote: >>> That said, we will look into this again, of course. Christoph, any idea? >> >> No idea really - this seems so far away from the code

RE: [GIT PULL] Block pull request for- 4.11-rc1

On 02/19/2017 11:35 PM, Christoph Hellwig wrote: > On Sun, Feb 19, 2017 at 06:15:41PM -0700, Jens Axboe wrote: >> That said, we will look into this again, of course. Christoph, any idea? > > No idea really - this seems so far away from the code touched, and there > are no obvious signs for a

Re: [PATCH 0/5] block subsystem refcounter conversions

On 02/20/2017 08:41 AM, James Bottomley wrote: > On Mon, 2017-02-20 at 08:15 -0700, Jens Axboe wrote: >> On 02/20/2017 04:16 AM, Elena Reshetova wrote: >>> Now when new refcount_t type and API are finally merged >>> (see include/linux/refcount.h), the following >>> patches convert various

Re: Some throughput tests with MQ and BFQ on MMC/SD

On 20/02/17 15:46, Linus Walleij wrote: > On Mon, Feb 20, 2017 at 9:03 AM, Adrian Hunter > wrote: > >> MQ is not better - it is just different. > > Well it is better in the sense that it has active maintainers and is > not scheduled > for depreciation. > >> Because

Re: [PATCH 0/5] block subsystem refcounter conversions

On 02/20/2017 04:16 AM, Elena Reshetova wrote: > Now when new refcount_t type and API are finally merged > (see include/linux/refcount.h), the following > patches convert various refcounters in the block susystem from atomic_t > to refcount_t. By doing this we prevent intentional or accidental >

Re: [PATCH 01/10] block: Move bdev_unhash_inode() after invalidate_partition()

On Sun 12-02-17 12:58:33, Tejun Heo wrote: > On Thu, Feb 09, 2017 at 01:44:24PM +0100, Jan Kara wrote: > > Move bdev_unhash_inode() after invalidate_partition() as > > invalidate_partition() looks up bdev and will unnecessarily recreate it > > if bdev_unhash_inode() destroyed it. Also use

[PATCH 0/5] block subsystem refcounter conversions

Now when new refcount_t type and API are finally merged (see include/linux/refcount.h), the following patches convert various refcounters in the block susystem from atomic_t to refcount_t. By doing this we prevent intentional or accidental underflows or overflows that can led to use-after-free

[PATCH 2/5] block: convert blk_queue_tag.refcnt from atomic_t to refcount_t

refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

[PATCH 4/5] block: convert io_context.active_ref from atomic_t to refcount_t

refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

[PATCH 3/5] block: convert blkcg_gq.refcnt from atomic_t to refcount_t

refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

[PATCH 5/5] block: convert bsg_device.ref_count from atomic_t to refcount_t

refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

Re: Some throughput tests with MQ and BFQ on MMC/SD

On 20/02/17 13:04, Ziji Hu wrote: > Hi Adrian, > > On 2017/2/20 16:03, Adrian Hunter wrote: >> On 17/02/17 15:22, Linus Walleij wrote: >>> On Fri, Feb 17, 2017 at 12:53 PM, Ziji Hu wrote: > >>> Ulf describes it: we want to switch MMC/SD to MQ. >>> >>> To me, there are two

[PATCH 1/5] block: convert bio.__bi_cnt from atomic_t to refcount_t

refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena Reshetova Signed-off-by:

Re: [PATCH] lightnvm: Fix error handling

On 02/19/2017 03:09 PM, Christophe JAILLET wrote: According to error handling in this function, it is likely that going to 'out' was expected here. Signed-off-by: Christophe JAILLET --- drivers/lightnvm/rrpc.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: Some throughput tests with MQ and BFQ on MMC/SD

Hi Adrian, On 2017/2/20 16:03, Adrian Hunter wrote: > On 17/02/17 15:22, Linus Walleij wrote: >> On Fri, Feb 17, 2017 at 12:53 PM, Ziji Hu wrote: >> Ulf describes it: we want to switch MMC/SD to MQ. >> >> To me, there are two reasons for that (no secret agendas...) >> >> 1.

Re: Some throughput tests with MQ and BFQ on MMC/SD

On 17/02/17 15:22, Linus Walleij wrote: > On Fri, Feb 17, 2017 at 12:53 PM, Ziji Hu wrote: > >> I would like to suggest that you should try the multiple thread >> test mode of iozone, since you are testing *Multi* Queue. > > Good point. This target has only 2