Re: [PATCHv2 1/2] blk-mq: Export blk_mq_freeze_queue_wait

2017-02-23 Thread Christoph Hellwig
Reviewed-by: Christoph Hellwig

Re: [PATCHv2 2/2] nvme: Complete all stuck requests

2017-02-23 Thread Christoph Hellwig
Thanks Keith, this looks much simpler so that even I can understand it :) Reviewed-by: Christoph Hellwig

Re: blk_integrity_revalidate() clears BDI_CAP_STABLE_WRITES

2017-02-23 Thread Martin K. Petersen
> "Ilya" == Ilya Dryomov writes: Ilya, Ilya> Well, blk_integrity_revalidate() doesn't clear the profile, it Ilya> just clears the stable pages flag. Whoever calls Ilya> blk_integrity_unregister() to clear the profile can also clear the Ilya> stable pages flag -- why not

[PATCHv2 1/2] blk-mq: Export blk_mq_freeze_queue_wait

2017-02-23 Thread Keith Busch
Drivers can start a freeze, so this provides a way to wait for frozen. Signed-off-by: Keith Busch --- block/blk-mq.c | 3 ++- include/linux/blk-mq.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index

[PATCHv2 2/2] nvme: Complete all stuck requests

2017-02-23 Thread Keith Busch
If the block layer has entered requests and gets a CPU hot plug event prior to the resume event, it will wait for those requests to exit. If the nvme driver is shutting down, it will not start the queues back up, preventing forward progress. To fix that, this patch freezes the request queues when

Re: Final opal patches for rc1

2017-02-23 Thread Jens Axboe
On 02/22/2017 10:15 AM, Scott Bauer wrote: > These are the final changes for rc1. > > Patch 1 contains some code to clean up an opal structure if something changes > at runtime. (already reviewed by Christoph) > > Patch 2 contains changes to the nvme driver to use the above patch. If a new > FW

Re: [PATCH v3 1/2] blk-mq: use sbq wait queues instead of restart for driver tags

2017-02-23 Thread Jens Axboe
On 02/22/2017 11:58 AM, Omar Sandoval wrote: > From: Omar Sandoval > > Commit 50e1dab86aa2 ("blk-mq-sched: fix starvation for multiple hardware > queues and shared tags") fixed one starvation issue for shared tags. > However, we can still get into a situation where we fail to

Re: [PATCH 1/4] f2fs: avoid very large discard command

2017-02-23 Thread Jaegeuk Kim
On 02/23, Christoph Hellwig wrote: > On Wed, Feb 22, 2017 at 08:28:47PM -0800, Jaegeuk Kim wrote: > > This patch adds MAX_DISCARD_BLOCKS() to avoid issuing too much large single > > discard command. > > Needs an explanation in the code on why this number was chosen. No need to add a trivial

RE:

2017-02-23 Thread Qin's Yanjun
How are you today and your family? I require your attention and honest co-operation about some issues which i will really want to discuss with you which. Looking forward to read from you soon. Qin's __ Sky Silk, http://aknet.kz

Re: sense handling improvements

2017-02-23 Thread Christoph Hellwig
On Thu, Feb 23, 2017 at 09:28:20AM -0500, Martin K. Petersen wrote: > > "Christoph" == Christoph Hellwig writes: > > Christoph, > > >> I applied 1-4 to 4.11/scsi-fixes. Both 5 and 6 had problems so please > >> fix those up. > > Christoph> What kind of problem? I didn't see

Re: sense handling improvements

2017-02-23 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph, >> I applied 1-4 to 4.11/scsi-fixes. Both 5 and 6 had problems so please >> fix those up. Christoph> What kind of problem? I didn't see anything on the list. They didn't apply. I tried to fix them up by hand. 5 was easy

Re: [PATCH] block/sed: Embed function data into the function sequence

2017-02-23 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig

Re: sense handling improvements

2017-02-23 Thread Christoph Hellwig
On Wed, Feb 22, 2017 at 07:51:44PM -0500, Martin K. Petersen wrote: > I applied 1-4 to 4.11/scsi-fixes. Both 5 and 6 had problems so please > fix those up. What kind of problem? I didn't see anything on the list.