Re: Re: Re: Question about gc time

2017-07-06 Thread Eric Wheeler
On Wed, 5 Jul 2017, tang.jun...@zte.com.cn wrote: > > Perhaps.  What is the total lock time that prevents IO?  Can you note > > those below? > > The total lock time that prevents IO is btree root node writer locker. > We take too much time in  btree_gc_mark_node - about 98% in GC, since > it is

Re: [GIT PULL] libnvdimm for 4.13

2017-07-06 Thread Al Viro
On Fri, Jul 07, 2017 at 12:22:38AM +, Williams, Dan J wrote: > Hi Linus, please pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm > tags/libnvdimm-for-4.13 > > to receive, libnvdimm updates for the latest ACPI and UEFI > specifications. This pull request also

[GIT PULL] libnvdimm for 4.13

2017-07-06 Thread Williams, Dan J
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm tags/libnvdimm-for-4.13 to receive, libnvdimm updates for the latest ACPI and UEFI specifications. This pull request also includes new 'struct dax_operations' enabling to undo the abuse [1] of

Re: [PATCH v2 1/1] null_blk: fix error flow for shared tags during module_init

2017-07-06 Thread Jens Axboe
On 07/06/2017 09:00 AM, Max Gurtovoy wrote: > In case we use shared tags feature, blk_mq_alloc_tag_set might fail > during module initialization. In that case, fail the load with the > suitble error code. Also move the tagset initialization process after > defining the amount of submition queues.

Re: [PATCH v3] block: Fix __blkdev_issue_zeroout loop

2017-07-06 Thread Jens Axboe
On 07/06/2017 05:21 AM, Damien Le Moal wrote: > The BIO issuing loop in __blkdev_issue_zeroout() is allocating BIOs > with a maximum number of bvec (pages) equal to > > min(nr_sects, (sector_t)BIO_MAX_PAGES) > > This works since the requested number of bvecs will always be limited > to the

[PATCH 3/4] fs: support RWF_NOWAIT for buffered reads

2017-07-06 Thread Christoph Hellwig
This is based on the old idea and code from Milosz Tanski. With the aio nowait code it becomes mostly trivial now. Buffered writes continue to return -EOPNOTSUPP if RWF_NOWAIT is passed. Signed-off-by: Christoph Hellwig --- fs/aio.c | 6 -- fs/btrfs/file.c| 9

[PATCH 4/4] block_dev: support RFW_NOWAIT on block device nodes

2017-07-06 Thread Christoph Hellwig
All support is already there in the generic code, we just need to wire it up. Signed-off-by: Christoph Hellwig --- fs/block_dev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/block_dev.c b/fs/block_dev.c index a7df151f8aba..f50026ec00c7 100644 --- a/fs/block_dev.c

[PATCH v2 1/1] null_blk: fix error flow for shared tags during module_init

2017-07-06 Thread Max Gurtovoy
In case we use shared tags feature, blk_mq_alloc_tag_set might fail during module initialization. In that case, fail the load with the suitble error code. Also move the tagset initialization process after defining the amount of submition queues. Signed-off-by: Max Gurtovoy ---

Re: [PATCH 1/1] null_blk: fix error flow for shared tags during module_init

2017-07-06 Thread Max Gurtovoy
On 7/6/2017 5:02 PM, Jens Axboe wrote: On 07/06/2017 07:24 AM, Max Gurtovoy wrote: In case we use shared tags feature, blk_mq_alloc_tag_set might fail during module initialization. Check the return value and default to run without shared tag set before continuing. Also move the tagset

Re: [PATCH 1/1] null_blk: fix error flow for shared tags during module_init

2017-07-06 Thread Jens Axboe
On 07/06/2017 07:24 AM, Max Gurtovoy wrote: > In case we use shared tags feature, blk_mq_alloc_tag_set might fail > during module initialization. Check the return value and default to run > without shared tag set before continuing. Also move the tagset > initialization process after defining the

[PATCH 1/1] null_blk: fix error flow for shared tags during module_init

2017-07-06 Thread Max Gurtovoy
In case we use shared tags feature, blk_mq_alloc_tag_set might fail during module initialization. Check the return value and default to run without shared tag set before continuing. Also move the tagset initialization process after defining the amount of submition queues. Signed-off-by: Max

[PATCH blktests] sg: add regression test for patch scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-06 Thread Johannes Thumshirn
Add a regression test for the patch titled "scsi: sg: fix SG_DXFER_FROM_DEV transfers" which reassembles the syscalls done by Nero Burning ROM to discover CD and DVD burners. Signed-off-by: Johannes Thumshirn --- common/sg | 2 +- src/.gitignore | 1

[PATCH v3] block: Fix __blkdev_issue_zeroout loop

2017-07-06 Thread Damien Le Moal
The BIO issuing loop in __blkdev_issue_zeroout() is allocating BIOs with a maximum number of bvec (pages) equal to min(nr_sects, (sector_t)BIO_MAX_PAGES) This works since the requested number of bvecs will always be limited to the absolute maximum number supported (BIO_MAX_PAGES), but this is

Re: OOPS from cciss_ioctl in 4.12+git

2017-07-06 Thread Meelis Roos
> Hi Meelis, > > can you try the patch below? Yes, the OOPS is gone and everything seems to be working. > Also we're trying to move people away from the cciss driver, can you > check if the hpsa SCSI driver works for you as well? I have older adapter: Compaq Computer Corporation Smart Array

Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints

2017-07-06 Thread Coly Li
On 2017/7/6 上午2:48, Christoph Hellwig wrote: > REQ_META should be purely a hint for blktrace, please don't use it > in the I/O path - that's what REQ_PRIO is for. > -- > To unsubscribe from this list: send the line "unsubscribe linux-bcache" in > the body of a message to majord...@vger.kernel.org

Re: [PATCH 8/8] xen-blockfront: quiesce IO before device removal

2017-07-06 Thread Sagi Grimberg
Looks the above change isn't needed since this blk_mq_start_stopped_hw_queues() should have been the counterpart of blk_mq_stop_hw_queue() in blkif_queue_rq(). Removed the patch altogether in v2 as I'm not convinced it is needed. I've only started reading the series, but to me it seems like