Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-28 Thread Brian King
On 07/28/2017 10:17 AM, Brian J King wrote: > Jens Axboe wrote on 07/28/2017 09:25:48 AM: > >> Can you try the below fix? Should be more palatable than the previous >> one. Brian, maybe you can take a look at the IRQ issue mentioned above? Michael, Does this address the issue

[PATCH BUGFIX] block, bfq: reset in_service_entity if it becomes idle

2017-07-28 Thread Paolo Valente
BFQ implements hierarchical scheduling by representing each group of queues with a generic parent entity. For each parent entity, BFQ maintains an in_service_entity pointer: if one of the child entities happens to be in service, in_service_entity points to it. The resetting of these pointers

Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support

2017-07-28 Thread Mike Snitzer
On Fri, Jul 28 2017 at 12:17pm -0400, Bart Van Assche wrote: > On Mon, 2017-04-17 at 12:09 -0700, Dan Williams wrote: > > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig > > index b7767da50c26..1de8372d9459 100644 > > --- a/drivers/md/Kconfig > > +++

Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support

2017-07-28 Thread Bart Van Assche
On Mon, 2017-04-17 at 12:09 -0700, Dan Williams wrote: > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig > index b7767da50c26..1de8372d9459 100644 > --- a/drivers/md/Kconfig > +++ b/drivers/md/Kconfig > @@ -200,6 +200,7 @@ config BLK_DEV_DM_BUILTIN > config BLK_DEV_DM > tristate

[GIT PULL] Block fixes for 4.13-rc3

2017-07-28 Thread Jens Axboe
Hi Linus, A small collection of fixes that should go into this series. This pull request contains: - NVMe pull request from Christoph, with various fixes for nvme proper and nvme-fc. - Disabling runtime PM for blk-mq for now. With scsi now defaulting to using blk-mq, this reared it's head

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-28 Thread Jens Axboe
On 07/28/2017 09:13 AM, Bart Van Assche wrote: > On Fri, 2017-07-28 at 08:25 -0600, Jens Axboe wrote: >> On 07/28/2017 12:19 AM, Michael Ellerman wrote: >>> OK, so the resolution is "fix it in IPR" ? >> >> I'll leave that to the SCSI crew. But at least one bug is in IPR, if you >> look at the call

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-28 Thread Bart Van Assche
On Fri, 2017-07-28 at 08:25 -0600, Jens Axboe wrote: > On 07/28/2017 12:19 AM, Michael Ellerman wrote: > > OK, so the resolution is "fix it in IPR" ? > > I'll leave that to the SCSI crew. But at least one bug is in IPR, if you > look at the call trace: > > - timer function triggers, runs

Re: [Xen-users] File-based domU - Slow storage write since xen 4.8

2017-07-28 Thread Benoit Depail
On 07/26/17 00:25, Keith Busch wrote: > On Fri, Jul 21, 2017 at 07:07:06PM +0200, Benoit Depail wrote: >> On 07/21/17 18:07, Roger Pau Monné wrote: >>> >>> Hm, I'm not sure I follow either. AFAIK this problem came from >>> changing the Linux version in the Dom0 (where the backend, blkback is >>>

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-28 Thread Jens Axboe
On 07/28/2017 12:19 AM, Michael Ellerman wrote: > Jens Axboe writes: >> On 07/27/2017 08:47 AM, Bart Van Assche wrote: >>> On Thu, 2017-07-27 at 08:02 -0600, Jens Axboe wrote: The bug looks like SCSI running the queue inline from IRQ context, that's not a good idea. >

Re: [PATCH V2] lightnvm: pblk fix for 4.13

2017-07-28 Thread Javier González
> On 28 Jul 2017, at 16.06, Jens Axboe wrote: > > On 07/28/2017 07:13 AM, Javier González wrote: >> Hi Jens, >> >> Can you pick up this fix for 4.13? It is a fix to a read corruption in >> pblk that has been there form the beginning. It is due to a bad bio >> manipulation in

Re: [PATCH V2] lightnvm: pblk fix for 4.13

2017-07-28 Thread Jens Axboe
On 07/28/2017 07:13 AM, Javier González wrote: > Hi Jens, > > Can you pick up this fix for 4.13? It is a fix to a read corruption in > pblk that has been there form the beginning. It is due to a bad bio > manipulation in the case that an I/O containing lbas that are invalid, > point to data in

[PATCH V2] lightnvm: pblk fix for 4.13

2017-07-28 Thread Javier González
Hi Jens, Can you pick up this fix for 4.13? It is a fix to a read corruption in pblk that has been there form the beginning. It is due to a bad bio manipulation in the case that an I/O containing lbas that are invalid, point to data in the host cache and point to data on the device, all three in

[PATCH] lightnvm: pblk: advance bio according to lba index

2017-07-28 Thread Javier González
When a lba either hits the cache or corresponds to an empty entry in the L2P table, we need to advance the bio according to the position in which the lba is located. Otherwise, we will copy data in the wrong page, thus causing data corruption for the application. In case of a cache hit, we

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-28 Thread Michael Ellerman
Jens Axboe writes: > On 07/27/2017 08:47 AM, Bart Van Assche wrote: >> On Thu, 2017-07-27 at 08:02 -0600, Jens Axboe wrote: >>> The bug looks like SCSI running the queue inline from IRQ >>> context, that's not a good idea. ... >> >> scsi_run_queue() works fine if no scheduler is