Re: [PATCH 04/14] blk-mq-sched: improve dispatching from sw queue

2017-08-02 Thread Ming Lei
On Thu, Aug 03, 2017 at 01:35:29AM +, Bart Van Assche wrote: > On Wed, 2017-08-02 at 11:31 +0800, Ming Lei wrote: > > On Tue, Aug 01, 2017 at 03:11:42PM +, Bart Van Assche wrote: > > > On Tue, 2017-08-01 at 18:50 +0800, Ming Lei wrote: > > > > On Tue, Aug 01, 2017 at 06:17:18PM +0800, Ming

Re: [PATCH 04/14] blk-mq-sched: improve dispatching from sw queue

2017-08-02 Thread Bart Van Assche
On Wed, 2017-08-02 at 11:31 +0800, Ming Lei wrote: > On Tue, Aug 01, 2017 at 03:11:42PM +, Bart Van Assche wrote: > > On Tue, 2017-08-01 at 18:50 +0800, Ming Lei wrote: > > > On Tue, Aug 01, 2017 at 06:17:18PM +0800, Ming Lei wrote: > > > > How can we get the accurate 'number of requests in

Re: [PATCH 05/14] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed

2017-08-02 Thread Bart Van Assche
On Wed, 2017-08-02 at 11:01 +0800, Ming Lei wrote: > On Tue, Aug 01, 2017 at 04:14:07PM +, Bart Van Assche wrote: > > On Tue, 2017-08-01 at 18:44 +0800, Ming Lei wrote: > > > On Mon, Jul 31, 2017 at 11:42:21PM +, Bart Van Assche wrote: > > > > Since setting, clearing and testing of

Re: [PATCH 03/14] blk-mq: introduce blk_mq_dispatch_rq_from_ctxs()

2017-08-02 Thread kbuild test robot
Hi Ming, [auto build test ERROR on block/for-next] [also build test ERROR on v4.13-rc3 next-20170802] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ming-Lei/blk-mq-sched-fix-SCSI-MQ

[PATCH 1/2] null_blk: simplify logic for use_per_node_hctx

2017-08-02 Thread weiping zhang
make sure submit_queues equal nr_online_nodes. Signed-off-by: weiping zhang --- drivers/block/null_blk.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c index 85c24ca..72e2bc5 100644 ---

[PATCH 0/2] null_blk: make sure submit_queues > 0

2017-08-02 Thread weiping zhang
Hi, two misc patch for null_blk, null_blk: simplify logic for use_per_node_hctx simplify code logic, if use_per_node_hctx set submit_queues same as nr_online_nodes. null_blk: make sure submit_queues > 0 set submit_queues to 1 by default, and add a handle for it's value < 0, no matter what user

Re: [Xen-users] File-based domU - Slow storage write since xen 4.8

2017-08-02 Thread Benoit Depail
On 08/01/2017 11:48 AM, Roger Pau Monné wrote: > On Fri, Jul 28, 2017 at 04:50:27PM +0200, Benoit Depail wrote: >> On 07/26/17 00:25, Keith Busch wrote: >>> On Fri, Jul 21, 2017 at 07:07:06PM +0200, Benoit Depail wrote: On 07/21/17 18:07, Roger Pau Monné wrote: > > Hm, I'm not sure I

[PATCH 2/2] null_blk: make sure submit_queues > 0

2017-08-02 Thread weiping zhang
set submit_queues to 1 by default, and make sure it's value > 0. Signed-off-by: weiping zhang --- drivers/block/null_blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c index

Re: [RFC PATCH] bio-integrity: Fix regression if profile verify_fn is NULL

2017-08-02 Thread Milan Broz
On 08/02/2017 04:11 PM, Martin K. Petersen wrote: >> And the integrity profile is perfect interface for this, we register >> own profile through the proper interface. (Any other solution for >> per-sector metadata would be worse, I tried...) > > The DM use case seems a bit weird and I would

Re: [PATCH] block: Add comment to submit_bio_wait()

2017-08-02 Thread Jens Axboe
On 08/02/2017 02:25 AM, Jan Kara wrote: > submit_bio_wait() does not consume bio reference. Add comment about > that. Thanks, added for 4.14. -- Jens Axboe

Re: [PATCH V2] blk-mq: don't leak preempt counter/q_usage_counter when allocating rq failed

2017-08-02 Thread Jens Axboe
On 08/01/2017 06:01 PM, Ming Lei wrote: > From: Ming Lei > > When blk_mq_get_request() failed, preempt counter isn't > released, and blk_mq_make_request() doesn't release the counter > too. > > This patch fixes the issue, and makes sure that preempt counter > is only held if

[PATCH 1/4] raid_class: Add 'JBOD' RAID level

2017-08-02 Thread Hannes Reinecke
Not a real RAID level, but some HBAs support JBOD in addition to the 'classical' RAID levels. Signed-off-by: Hannes Reinecke --- drivers/scsi/raid_class.c | 1 + include/linux/raid_class.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/scsi/raid_class.c

[PATCH 0/4] mylex: Replace DAC960 block driver

2017-08-02 Thread Hannes Reinecke
Hi all, as we're trying to get rid of the remaining request_fn drivers here's a patchset to move the DAC960 driver to the SCSI stack. The new driver is called 'mylex'. The Mylex/DAC960 HBA comes in two flavours; the later one (V2) already has a pretty complete SCSI emulation layer, so we just

[PATCH 2/4] scsi: Add VENDOR_SPECIFIC sense code definitions

2017-08-02 Thread Hannes Reinecke
Some older devices will return vendor specific sense codes, so we should be adding a definition for it. Signed-off-by: Hannes Reinecke --- include/scsi/scsi_proto.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/scsi/scsi_proto.h b/include/scsi/scsi_proto.h index

Re: [RFC PATCH] bio-integrity: Fix regression if profile verify_fn is NULL

2017-08-02 Thread Martin K. Petersen
Milan, > And the integrity profile is perfect interface for this, we register > own profile through the proper interface. (Any other solution for > per-sector metadata would be worse, I tried...) The DM use case seems a bit weird and I would like to take a closer look later (a storm took out

Re: [RFC PATCH] bio-integrity: Fix regression if profile verify_fn is NULL

2017-08-02 Thread Christoph Hellwig
On Wed, Aug 02, 2017 at 02:27:50PM +0200, Milan Broz wrote: > In dm-integrity target we register integrity profile that have > both generate_fn and verify_fn callbacks set to NULL. > > This is used if dm-integrity is stacked under a dm-crypt device > for authenticated encryption (integrity

[RFC PATCH] bio-integrity: Fix regression if profile verify_fn is NULL

2017-08-02 Thread Milan Broz
In dm-integrity target we register integrity profile that have both generate_fn and verify_fn callbacks set to NULL. This is used if dm-integrity is stacked under a dm-crypt device for authenticated encryption (integrity payload contains authentication tag and IV seed). In this case the

[PATCH] block: Add comment to submit_bio_wait()

2017-08-02 Thread Jan Kara
submit_bio_wait() does not consume bio reference. Add comment about that. Signed-off-by: Jan Kara --- block/bio.c | 4 1 file changed, 4 insertions(+) diff --git a/block/bio.c b/block/bio.c index 9a63597aaacc..e241bbc49f14 100644 --- a/block/bio.c +++ b/block/bio.c @@ -936,6