Re: [PATCH 4/5] bcache: writeback: collapse contiguous IO better

2017-09-29 Thread Michael Lyle
Coly-- What you say is correct-- it has a few changes from current behavior. - When writeback rate is low, it is more willing to do contiguous I/Os. This provides an opportunity for the IO scheduler to combine operations together. The cost of doing 5 contiguous I/Os and 1 I/O is usually about

Re: [PATCH 4/5] bcache: writeback: collapse contiguous IO better

2017-09-29 Thread Coly Li
On 2017/9/27 下午3:32, tang.jun...@zte.com.cn wrote: > From: Tang Junhui > > Hello Mike: > > For the second question, I thinks this modification is somewhat complex, > cannot we do something simple to resolve it? I remember there were some > patches trying to avoid too

[PATCH v2] null_blk: add "no_sched" module parameter

2017-09-29 Thread weiping zhang
add an option that disable io scheduler for null block device. Signed-off-by: weiping zhang --- drivers/block/null_blk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c index bd92286..38f4a8c 100644 ---

Re: [PATCH] null_blk: add "no_sched" module parameter

2017-09-29 Thread weiping zhang
On Fri, Sep 29, 2017 at 11:39:03PM +0200, Jens Axboe wrote: > On 09/29/2017 07:09 PM, weiping zhang wrote: > > add an option that disable io scheduler for null block device. > > > > Signed-off-by: weiping zhang > > --- > > drivers/block/null_blk.c | 6 +- > > 1

Re: [PATCH 2/2] nvme: use device_add_disk_with_groups()

2017-09-29 Thread Keith Busch
On Thu, Sep 28, 2017 at 09:36:37PM +0200, Martin Wilck wrote: > By using device_add_disk_with_groups(), we can avoid the race > condition with udev rule processing, because no udev event will > be triggered before all attributes are available. > > Signed-off-by: Martin Wilck

Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups

2017-09-29 Thread Keith Busch
On Thu, Sep 28, 2017 at 09:36:36PM +0200, Martin Wilck wrote: > In the NVME subsystem, we're seeing a race condition with udev where > device_add_disk() is called (which triggers an "add" uevent), and a > sysfs attribute group is added to the disk device afterwards. > If udev rules access these

Re: [PATCH] null_blk: add "no_sched" module parameter

2017-09-29 Thread Jens Axboe
On 09/29/2017 07:09 PM, weiping zhang wrote: > add an option that disable io scheduler for null block device. > > Signed-off-by: weiping zhang > --- > drivers/block/null_blk.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

RE: [PATCH 2/2] nvme: use device_add_disk_with_groups()

2017-09-29 Thread Schremmer, Steven
> From: Linux-nvme [mailto:linux-nvme-boun...@lists.infradead.org] On Behalf Of > Martin Wilck > Sent: Thursday, September 28, 2017 2:37 PM > To: Jens Axboe ; Christoph Hellwig ; Johannes > Thumshirn > Cc: linux-block@vger.kernel.org; Martin

RE: [PATCH 1/2] block: genhd: add device_add_disk_with_groups

2017-09-29 Thread Schremmer, Steven
> From: Linux-nvme [mailto:linux-nvme-boun...@lists.infradead.org] On Behalf Of > Martin Wilck > Sent: Thursday, September 28, 2017 2:37 PM > To: Jens Axboe ; Christoph Hellwig ; Johannes > Thumshirn > Cc: linux-block@vger.kernel.org; Martin

Re: [PATCH V6 0/6] block/scsi: safe SCSI quiescing

2017-09-29 Thread Martin Steigerwald
Ming Lei - 27.09.17, 16:27: > On Wed, Sep 27, 2017 at 09:57:37AM +0200, Martin Steigerwald wrote: > > Hi Ming. > > > > Ming Lei - 27.09.17, 13:48: > > > Hi, > > > > > > The current SCSI quiesce isn't safe and easy to trigger I/O deadlock. > > > > > > Once SCSI device is put into QUIESCE, no new

Re: [PATCH 8/9] nvme: implement multipath access to nvme subsystems

2017-09-29 Thread Tony Yang
Hi, All Because my environment requirements, the kernel must use 4.8.17, I would like to ask, how to use the kernel 4.8.17 nvme multi-path? Because I see support for multi-path versions are above 4.13 Expect everyone's help, thank you very much 2017-09-28 23:53 GMT+08:00 Keith Busch