Re: [PATCH V4] scsi_debugfs: fix crash in scsi_show_rq()

2017-11-13 Thread Ming Lei
Hi James, On Mon, Nov 13, 2017 at 10:55:52AM -0800, James Bottomley wrote: > On Sat, 2017-11-11 at 10:43 +0800, Ming Lei wrote: > > On Fri, Nov 10, 2017 at 08:51:58AM -0800, James Bottomley wrote: > > > > > > On Fri, 2017-11-10 at 17:01 +0800, Ming Lei wrote: > > > > > > > > cmd->cmnd can be

Re: [PATCH V2] block-throttle: avoid double charge

2017-11-13 Thread Tejun Heo
On Mon, Nov 13, 2017 at 12:37:10PM -0800, Shaohua Li wrote: > If a bio is throttled and splitted after throttling, the bio could be > resubmited and enters the throttling again. This will cause part of the > bio is charged multiple times. If the cgroup has an IO limit, the double > charge will

Re: [PATCH] block-throttle: avoid double charge

2017-11-13 Thread Tejun Heo
On Mon, Nov 13, 2017 at 12:03:38PM -0800, Tejun Heo wrote: > So, one question I have is whether we need both BIO_THROTTLED and > bi_throttled_disk. Can't we replace BIO_THROTTLED w/ > bi_throttled_disk? IOW, won't something like the following work? (not tested yet) Thanks. --- block/bio.c

[PATCH V2] block-throttle: avoid double charge

2017-11-13 Thread Shaohua Li
If a bio is throttled and splitted after throttling, the bio could be resubmited and enters the throttling again. This will cause part of the bio is charged multiple times. If the cgroup has an IO limit, the double charge will significantly harm the performance. The bio split becomes quite common

Re: [PATCH] block-throttle: avoid double charge

2017-11-13 Thread Tejun Heo
Hello, Shaohua. On Fri, Oct 13, 2017 at 11:10:29AM -0700, Shaohua Li wrote: > If a bio is throttled and splitted after throttling, the bio could be > resubmited and enters the throttling again. This will cause part of the > bio is charged multiple times. If the cgroup has an IO limit, the double

Re: [PATCH V4] scsi_debugfs: fix crash in scsi_show_rq()

2017-11-13 Thread James Bottomley
On Sat, 2017-11-11 at 10:43 +0800, Ming Lei wrote: > On Fri, Nov 10, 2017 at 08:51:58AM -0800, James Bottomley wrote: > > > > On Fri, 2017-11-10 at 17:01 +0800, Ming Lei wrote: > > > > > > cmd->cmnd can be allocated/freed dynamically in case of > > > T10_PI_TYPE2_PROTECTION, so we should check

Re: [PATCH IMPROVEMENT/BUGFIX 0/4] block, bfq: increase sustainable IOPS and fix a bug

2017-11-13 Thread Jens Axboe
On 11/12/2017 11:34 PM, Paolo Valente wrote: > Hi, > these patches address the following issue, raised and > discussed in [1]. > > BFQ provides a proportional share policy for the blkio controller. In > this respect, BFQ updates the I/O accounting related to its policy, > i.e., the statistics

Re:

2017-11-13 Thread Amos Kalonzo
Attn: I am wondering why You haven't respond to my email for some days now. reference to my client's contract balance payment of (11.7M,USD) Kindly get back to me for more details. Best Regards Amos Kalonzo