Re: [PATCH V3 7/8] scsi: hpsa: improve scsi_mq performance via .host_tagset

> + /* 256 tags should be high enough to saturate device */ > + int max_queues = DIV_ROUND_UP(h->scsi_host->can_queue, 256); > + > + /* per NUMA node hw queue */ > + h->scsi_host->nr_hw_queues = min_t(int, nr_node_ids, max_queues); I don't think this magic should be in a driver.

Re: [PATCH V3 4/8] blk-mq: introduce BLK_MQ_F_HOST_TAGS

On Tue, Feb 27, 2018 at 06:07:46PM +0800, Ming Lei wrote: > This patch can support to partition host-wide tags to multiple hw queues, > so each hw queue related data structures(tags, hctx) can be accessed in > NUMA locality way, for example, the hw queue can be per NUMA node. > > It is observed

Re: [PATCH V3 3/8] blk-mq: introduce 'start_tag' field to 'struct blk_mq_tags'

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

> +static void hpsa_setup_reply_map(struct ctlr_info *h) > +{ > + const struct cpumask *mask; > + unsigned int queue, cpu; > + > + for (queue = 0; queue < h->msix_vectors; queue++) { > + mask = pci_irq_get_affinity(h->pdev, queue); > + if (!mask) > +

Re: [PATCH V2 3/5] genirq/affinity: move actual irq vector spread into one helper

Can you fix this up and resend? On Tue, Mar 06, 2018 at 12:28:32AM +0800, kbuild test robot wrote: > Hi Ming, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on tip/irq/core] > [also build test WARNING on v4.16-rc4 next-20180305] > [if your patch is

[PATCH] block: bio_check_eod() needs to consider partition

bio_check_eod() should check partiton size not the whole disk if bio->bi_partno is non-zero. Based on an earlier patch from Jiufei Xue. Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index") Reported-by: Jiufei Xue

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

On Wed, Mar 07, 2018 at 10:58:34PM +0530, Kashyap Desai wrote: > > > > > > Also one observation using V3 series patch. I am seeing below Affinity > > > mapping whereas I have only 72 logical CPUs. It means we are really > > > not going to use all reply queues. > > > e.a If I bind fio jobs on CPU

[PATCH v2 03/11] block: Introduce blk_queue_flag_{set,clear,test_and_{set,clear}}()

Introduce functions that modify the queue flags and that protect these modifications with the request queue lock. Except for moving one wake_up_all() call from inside to outside a critical section, this patch does not change any functionality. Signed-off-by: Bart Van Assche

[PATCH v2 11/11] block: Move the queue_flag_*() functions from a public into a private header file

This patch helps to avoid that new code gets introduced in block drivers that manipulates queue flags without holding the queue lock when that lock should be held. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Reviewed-by: Martin K.

[PATCH v2 00/11] Make all concurrent queue flag manipulations safe

Hello Jens, As you probably know there is considerable confusion in the block layer core and in block drivers about how to protect queue flag changes against concurrent modifications. Some code protects these changes with the queue lock, other code uses atomic operations and some code does not

[PATCH v2 07/11] iscsi: Use blk_queue_flag_set()

Use blk_queue_flag_set() instead of open-coding this function. Signed-off-by: Bart Van Assche Acked-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn Cc: Christoph Hellwig Cc: Hannes Reinecke

[PATCH v2 01/11] block: Reorder the queue flag manipulation function definitions

Move the definition of queue_flag_clear_unlocked() up and move the definition of queue_in_flight() down such that all queue flag manipulation function definitions become contiguous. This patch does not change any functionality. Signed-off-by: Bart Van Assche Reviewed-by:

[PATCH v2 10/11] block: Complain if queue_flag_(set|clear)_unlocked() is abused

Since it is not safe to use queue_flag_(set|clear)_unlocked() without holding the queue lock after the sysfs entries for a queue have been created, complain if this happens. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Reviewed-by:

[PATCH v2 06/11] bcache: Use the blk_queue_flag_{set,clear}() functions

Use the blk_queue_flag_{set,clear}() functions instead of open-coding these. Signed-off-by: Bart Van Assche Reviewed-by: Michael Lyle Reviewed-by: Johannes Thumshirn Reviewed-by: Martin K. Petersen Cc:

[PATCH v2 05/11] mtip32xx: Use the blk_queue_flag_*() functions

Use the blk_queue_flag_*() functions instead of open-coding these. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Reviewed-by: Martin K. Petersen Cc: Christoph Hellwig Cc: Hannes Reinecke

[PATCH v2 02/11] block: Use the queue_flag_*() functions instead of open-coding these

Except for changing the atomic queue flag manipulations that are protected by the queue lock into non-atomic manipulations, this patch does not change any functionality. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Reviewed-by:

[PATCH v2 04/11] block: Protect queue flag changes with the queue lock

Since the queue flags may be changed concurrently from multiple contexts after a queue becomes visible in sysfs, make these changes safe by protecting these with the queue lock. Signed-off-by: Bart Van Assche Reviewed-by: Martin K. Petersen

[PATCH v2 08/11] target/tcm_loop: Use blk_queue_flag_set()

Use blk_queue_flag_set() instead of open-coding this function. Signed-off-by: Bart Van Assche Reviewed-by: Johannes Thumshirn Reviewed-by: Martin K. Petersen Cc: Nicholas A. Bellinger Cc: Christoph

Re: [PATCH v7 2/2] Return bytes transferred for partial direct I/O

On Thu, Feb 08, 2018 at 12:59:48PM -0600, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > In case direct I/O encounters an error midway, it returns the error. > Instead it should be returning the number of bytes transferred so far. > > Test case for filesystems (with

Re: [PATCH v2] block: sed-opal: fix u64 short atom length

On Wed, Mar 07, 2018 at 04:24:29PM -0700, Scott Bauer wrote: > On Wed, Mar 07, 2018 at 05:55:56PM +0100, Jonas Rabenstein wrote: > > The length must be given as bytes and not as 4 bit tuples. > > > > Signed-off-by: Jonas Rabenstein > > --- > > v2: > >

Re: [PATCH v2] block: sed-opal: fix u64 short atom length

On Wed, Mar 07, 2018 at 05:55:56PM +0100, Jonas Rabenstein wrote: > The length must be given as bytes and not as 4 bit tuples. > > Signed-off-by: Jonas Rabenstein > --- > v2: > - use fls64 > - shorten loop body > --- > block/sed-opal.c | 11

Re: [PATCH][RESEND] block: sed-opal: fix response string extraction

On Tue, Mar 06, 2018 at 04:23:24PM -0800, Derrick, Jonathan wrote: > This looks correct. > > Adding my Ack unless Scott has objections > > Acked-by: Jonathan Derrick Reviewed-by: Scott Bauer Nice catch Jonas! Sorry you had to resend, my

RE: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

> > > > Also one observation using V3 series patch. I am seeing below Affinity > > mapping whereas I have only 72 logical CPUs. It means we are really > > not going to use all reply queues. > > e.a If I bind fio jobs on CPU 18-20, I am seeing only one reply queue > > is used and that may lead to

Re: [PATCH v2] bcache: move closure debug file into debug direcotry

On 03/06/2018 07:23 PM, Chengguang Xu wrote: > In current code closure debug file is outside of debug directory > and when unloading module there is lack of removing operation > for closure debug file, so it will cause creating error when trying > to reload module. > > This patch move closure

[PATCH v2] block: sed-opal: fix u64 short atom length

The length must be given as bytes and not as 4 bit tuples. Signed-off-by: Jonas Rabenstein --- v2: - use fls64 - shorten loop body --- block/sed-opal.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/block/sed-opal.c

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

On Wed, Mar 07, 2018 at 08:31:31PM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Wednesday, March 7, 2018 10:58 AM > > To: Kashyap Desai > > Cc: Jens Axboe; linux-block@vger.kernel.org; Christoph Hellwig; Mike > Snitzer; > >

RE: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Wednesday, March 7, 2018 10:58 AM > To: Kashyap Desai > Cc: Jens Axboe; linux-block@vger.kernel.org; Christoph Hellwig; Mike Snitzer; > linux-s...@vger.kernel.org; Hannes Reinecke; Arun Easi; Omar Sandoval; > Martin

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

On Tue, 2018-03-06 at 14:24 -0500, Martin K. Petersen wrote: > Ming, > > > Given both Don and Laurence have verified that patch 1 and patch 2 > > does fix IO hang, could you consider to merge the two first? > > Oh, and I would still need a formal Acked-by: from Don and Tested-by: > from