Re: disk-io lockup in 4.14.13 kernel

On Sun, 2018-03-11 at 06:33 +0200, Jaco Kroon wrote: > crowsnest ~ # find /sys -name sdm > /sys/kernel/debug/block/sdm > /sys/devices/pci:00/:00:01.0/:01:00.0/host0/port-0:0/expander-0:0/port-0:0:0/expander-0:1/port-0:1:0/end_device-0:1:0/target0:0:13/0:0:13:0/block/sdm >

Re: disk-io lockup in 4.14.13 kernel

rnel/debug/block && find . -type f -exec grep -aH . {} \;) >> Looks like the lockups are far more frequent with everything on mq. >> Just to confirm: >> >> CONFIG_SCSI_MQ_DEFAULT=y >> CONFIG_DM_MQ_DEFAULT=y >> >> >> Please find attac

Re: disk-io lockup in 4.14.13 kernel

; > Looks like the lockups are far more frequent with everything on mq. > Just to confirm: > > CONFIG_SCSI_MQ_DEFAULT=y > CONFIG_DM_MQ_DEFAULT=y > > > Please find attached the output from the requested. > > http://downloads.uls.co.za/lockup/lockup-20180310-223036/ c

Re: [PATCH] scsi: resolve COMMAND_SIZE at compile time

On 2018-03-10 03:49 PM, James Bottomley wrote: On Sat, 2018-03-10 at 14:29 +0100, Stephen Kitt wrote: Hi Bart, On Fri, 9 Mar 2018 22:47:12 +, Bart Van Assche wrote: On Fri, 2018-03-09 at 23:33 +0100, Stephen Kitt wrote: +/* + * SCSI command sizes are as

Re: [PATCH] scsi: resolve COMMAND_SIZE at compile time

On Sat, 2018-03-10 at 14:29 +0100, Stephen Kitt wrote: > Hi Bart, > > On Fri, 9 Mar 2018 22:47:12 +, Bart Van Assche c.com> > wrote: > > > > On Fri, 2018-03-09 at 23:33 +0100, Stephen Kitt wrote: > > > > > > +/* > > > + * SCSI command sizes are as follows, in bytes, for

Re: [PATCH] scsi: resolve COMMAND_SIZE at compile time

Hi Bart, On Fri, 9 Mar 2018 22:47:12 +, Bart Van Assche wrote: > On Fri, 2018-03-09 at 23:33 +0100, Stephen Kitt wrote: > > +/* > > + * SCSI command sizes are as follows, in bytes, for fixed size commands, > > per > > + * group: 6, 10, 10, 12, 16, 12, 10, 10. The top

Re: [PATCH V4 1/4] scsi: hpsa: fix selection of reply queue

On Sat, Mar 10, 2018 at 11:09:59AM +0100, Christoph Hellwig wrote: > > +static void hpsa_setup_reply_map(struct ctlr_info *h) > > +{ > > + const struct cpumask *mask; > > + unsigned int queue, cpu; > > + > > + for (queue = 0; queue < h->msix_vectors; queue++) { > > + mask =

Re: [PATCH] device_handler: remove VLAs

Hi Bart, On Fri, 9 Mar 2018 22:48:10 +, Bart Van Assche wrote: > On Fri, 2018-03-09 at 23:32 +0100, Stephen Kitt wrote: > > In preparation to enabling -Wvla, remove VLAs and replace them with > > fixed-length arrays instead. > > > > scsi_dh_{alua,emc,rdac} use

Re: [PATCH V4 4/4] scsi: virtio_scsi: fix IO hang caused by irq vector automatic affinity

This looks generally fine to me: Reviewed-by: Christoph Hellwig As a follow on we should probably kill virtscsi_queuecommand_single and thus virtscsi_host_template_single as well. > Given storage IO is always C/S model, there isn't such issue with > SCSI_MQ(blk-mq), What does C/S

Re: [PATCH V4 3/4] scsi: introduce force_blk_mq

On Fri, Mar 09, 2018 at 11:32:17AM +0800, Ming Lei wrote: > >From scsi driver view, it is a bit troublesome to support both blk-mq > and non-blk-mq at the same time, especially when drivers need to support > multi hw-queue. > > This patch introduces 'force_blk_mq' to scsi_host_template so that

Re: [PATCH V4 1/4] scsi: hpsa: fix selection of reply queue

> +static void hpsa_setup_reply_map(struct ctlr_info *h) > +{ > + const struct cpumask *mask; > + unsigned int queue, cpu; > + > + for (queue = 0; queue < h->msix_vectors; queue++) { > + mask = pci_irq_get_affinity(h->pdev, queue); > + if (!mask) > +