Re: blktests block/019 lead system hang

2018-06-05 Thread Yi Zhang
Here is the output, and I can see "HotPlug+ Surprise+" on SltCap # lspci -vvv -s :83:05.0 83:05.0 PCI bridge: PLX Technology, Inc. PEX 8734 32-lane, 8-Port PCI Express Gen 3 (8.0GT/s) Switch (rev ab) (prog-if 00 [Normal decode])     Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV-

Re: blktests block/019 lead system hang

2018-06-05 Thread Keith Busch
On Tue, Jun 05, 2018 at 10:18:53AM -0600, Keith Busch wrote: > On Wed, May 30, 2018 at 03:26:54AM -0400, Yi Zhang wrote: > > Hi Keith > > I found blktest block/019 also can lead my NVMe server hang with > > 4.17.0-rc7, let me know if you need more info, thanks. > > > > Server: Dell R730xd > >

Re: blktests block/019 lead system hang

2018-06-05 Thread Keith Busch
On Wed, May 30, 2018 at 03:26:54AM -0400, Yi Zhang wrote: > Hi Keith > I found blktest block/019 also can lead my NVMe server hang with 4.17.0-rc7, > let me know if you need more info, thanks. > > Server: Dell R730xd > NVMe SSD: 85:00.0 Non-Volatile memory controller: Samsung Electronics Co Ltd

Re: [PATCH] nbd: set discard_alignment to the granularity

2018-06-05 Thread Jens Axboe
On 6/5/18 9:41 AM, Josef Bacik wrote: > Technically we should be able to get away with 0 as the > discard_alignment, but there's no way currently for the protocol to > indicate different alignments, and in real life most disks have > discard_alignment == discard_granularity. Just set our

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Jens Axboe
On 6/4/18 10:40 AM, kvi...@gmail.com wrote: > From: Kevin Vigor > > Existing dev_dbg messages sometimes identify request using request > pointer, sometimes using nbd_cmd pointer. This makes it hard to > follow request flow. Consistently use request pointer instead. Applied, with the SOB added.

[PATCH] nbd: set discard_alignment to the granularity

2018-06-05 Thread Josef Bacik
Technically we should be able to get away with 0 as the discard_alignment, but there's no way currently for the protocol to indicate different alignments, and in real life most disks have discard_alignment == discard_granularity. Just set our alignment to our blocksize to make sure discards will

Re: [PATCH -next] lightnvm: pblk: make symbol write_buffer_size static

2018-06-05 Thread Jens Axboe
On 6/5/18 3:15 AM, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/lightnvm/pblk-init.c:23:14: warning: > symbol 'write_buffer_size' was not declared. Should it be static? Added, thanks. -- Jens Axboe

Re: [PATCH -v2] loop: add recursion validation to LOOP_CHANGE_FD

2018-06-05 Thread Jens Axboe
On 6/5/18 8:51 AM, Theodore Y. Ts'o wrote: > On Tue, Jun 05, 2018 at 10:04:56PM +0900, Tetsuo Handa wrote: >> I noticed that this patch is forgotten at ext4.git#loop-fix and therefore >> is not available at linux-next.git . Please be sure to include for 4.18 . > > I was assuming Jens was going to

[GIT PULL] Block fixes for 4.18-rc

2018-06-05 Thread Jens Axboe
Hi Linus, This just contains the dm kzalloc fix that was discussed, and a fix that I queued up yesterday for a case where blk-mq doesn't honor the stop bit appropriately. Please pull! git://git.kernel.dk/linux-block.git tags/for-linus-20180605

Re: [PATCH -v2] loop: add recursion validation to LOOP_CHANGE_FD

2018-06-05 Thread Theodore Y. Ts'o
On Tue, Jun 05, 2018 at 10:04:56PM +0900, Tetsuo Handa wrote: > I noticed that this patch is forgotten at ext4.git#loop-fix and therefore > is not available at linux-next.git . Please be sure to include for 4.18 . I was assuming Jens was going to send it to Linus, after he does a review. I could

Re: [PATCH] Revert "block: Add warning for bi_next not NULL in bio_endio()"

2018-06-05 Thread Bart Van Assche
On Mon, 2018-06-04 at 18:41 -0400, Kent Overstreet wrote: > On Mon, Jun 04, 2018 at 08:59:39AM +, Bart Van Assche wrote: > > Please comment out the getuid_callout line from /etc/multipath.conf and try > > again. > > Changing the "/..." part into the path of the srp-test software should also

Re: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs

2018-06-05 Thread Keith Busch
On Tue, Jun 05, 2018 at 06:47:33AM +0200, Christoph Hellwig wrote: > But let's assume we don't want to use the list due to this concern: > we'd still have to read the log page, as per the NVMe spec the only > think clearing a pending AEN is reading the associated log page. > We'd then need to

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Jens Axboe
On 6/5/18 8:30 AM, Josef Bacik wrote: > On Tue, Jun 05, 2018 at 08:23:06AM -0600, Jens Axboe wrote: >> On 6/4/18 10:40 AM, kvi...@gmail.com wrote: >>> From: Kevin Vigor >>> >>> Existing dev_dbg messages sometimes identify request using request >>> pointer, sometimes using nbd_cmd pointer. This

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Josef Bacik
On Tue, Jun 05, 2018 at 08:23:06AM -0600, Jens Axboe wrote: > On 6/4/18 10:40 AM, kvi...@gmail.com wrote: > > From: Kevin Vigor > > > > Existing dev_dbg messages sometimes identify request using request > > pointer, sometimes using nbd_cmd pointer. This makes it hard to > > follow request flow.

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Jens Axboe
On 6/4/18 10:40 AM, kvi...@gmail.com wrote: > From: Kevin Vigor > > Existing dev_dbg messages sometimes identify request using request > pointer, sometimes using nbd_cmd pointer. This makes it hard to > follow request flow. Consistently use request pointer instead. You're missing the

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Josef Bacik
On Mon, Jun 04, 2018 at 10:40:12AM -0600, kvi...@gmail.com wrote: > From: Kevin Vigor > > Existing dev_dbg messages sometimes identify request using request > pointer, sometimes using nbd_cmd pointer. This makes it hard to > follow request flow. Consistently use request pointer instead.

Re: [PATCH -v2] loop: add recursion validation to LOOP_CHANGE_FD

2018-06-05 Thread Tetsuo Handa
I noticed that this patch is forgotten at ext4.git#loop-fix and therefore is not available at linux-next.git . Please be sure to include for 4.18 . On 2018/05/08 0:37, Theodore Ts'o wrote: > Refactor the validation code used in LOOP_SET_FD so it is also used in > LOOP_CHANGE_FD. Otherwise it is

[PATCH -next] lightnvm: pblk: make symbol write_buffer_size static

2018-06-05 Thread Wei Yongjun
Fixes the following sparse warning: drivers/lightnvm/pblk-init.c:23:14: warning: symbol 'write_buffer_size' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/lightnvm/pblk-init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git