Re: [PATCH] bcache: set max writeback rate when I/O request is idle

2018-07-22 Thread Stefan Priebe - Profihost AG
Hi Coly, thanks for this patch. I was right on the way to debug why i have lot's of stalled I/O on latest SLES12-SP3 kernel. I'll add this patch and try if this solves my issues. Each cache set has two backing devices. Greets, Stefan Am 22.07.2018 um 18:13 schrieb Coly Li: > Commit b1092c9af9e

Re: [PATCH] blk-mq: fail the request in case issue failure

2018-07-22 Thread Jens Axboe
On 7/22/18 12:10 AM, Ming Lei wrote: > Inside blk_mq_try_issue_list_directly(), if the request is issued as > failed, we shouldn't try to do it again, otherwise the warning in > blk_mq_start_request() will be triggered. This change is aligned to > behaviour of other ways of request issue & dispatch

Hello Beautiful

2018-07-22 Thread Jack
Hi Dear, my name is Jack and i am seeking for a relationship in which i will feel loved after a series of failed relationships. I am hoping that you would be interested and we could possibly get to know each other more if you do not mind. I am open to answering questions from you as i think my

Re: [PATCH] blk-rq-qos: make depth comparisons unsigned

2018-07-22 Thread Jens Axboe
On 7/19/18 7:42 PM, Josef Bacik wrote: > With the change to use UINT_MAX I broke the depth check as any value of > inflight (ie 0) would be less than (int)UINT_MAX. Fix this by changing > everything to unsigned int to match the depth. Applied, thanks. -- Jens Axboe

[PATCH] bcache: set max writeback rate when I/O request is idle

2018-07-22 Thread Coly Li
Commit b1092c9af9ed ("bcache: allow quick writeback when backing idle") allows the writeback rate to be faster if there is no I/O request on a bcache device. It works well if there is only one bcache device attached to the cache set. If there are many bcache devices attached to a cache set, it may

Re: [Bug] block/for-next: IO hang in rq_qos_throttle

2018-07-22 Thread Josef Bacik
Ugh crap it’s in wbt. I’ll take a look when I’m back from vacation. Thanks, Josef Sent from my iPhone > On Jul 22, 2018, at 3:28 AM, Ming Lei wrote: > >> On Sun, Jul 22, 2018 at 02:15:38AM +, Josef Bacik wrote: >> Yup I sent a patch for this on Thursday, sorry about that, >> > > I just

[PATCH 2/2] nvme: use blk API to remap ref tags for IOs with metadata

2018-07-22 Thread Max Gurtovoy
Also moved the logic of the remapping to the nvme core driver instead of implementing it in the nvme pci driver. This way all the other nvme transport drivers will benefit from it (in case they'll implement metadata support). Suggested-by: Christoph Hellwig Cc: Jens Axboe Cc: Martin K. Petersen

[PATCH 1/2] block: move dif_prepare/dif_complete functions to block layer

2018-07-22 Thread Max Gurtovoy
Currently these functions are implemented in the scsi layer, but their actual place should be the block layer since T10-PI is a general data integrity feature that is used in the nvme protocol as well. Suggested-by: Christoph Hellwig Cc: Jens Axboe Cc: Martin K. Petersen Signed-off-by: Max Gurt

Re: [Bug] block/for-next: IO hang in rq_qos_throttle

2018-07-22 Thread Ming Lei
On Sun, Jul 22, 2018 at 02:15:38AM +, Josef Bacik wrote: > Yup I sent a patch for this on Thursday, sorry about that, > I just applied the patch of 'blk-rq-qos: make depth comparisons unsigned', looks the same IO hang can be triggered too. Thanks, Ming