On Mon, 2018-07-30 at 10:57 +0200, Hannes Reinecke wrote:
> On 07/30/2018 10:56 AM, Christoph Hellwig wrote:
> > I really don't see the point for this change.
>
> Okay, I'll be dropping it on the next iteration.
Hello Hannes,
Have you already decided when you will post the next iteration of
On Mon, 2018-07-30 at 09:12 +0200, Hannes Reinecke wrote:
> @@ -3061,11 +3066,7 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl,
> unsigned nsid)
>
> nvme_get_ctrl(ctrl);
>
> - device_add_disk(ctrl->device, ns->disk, NULL);
> - if (sysfs_create_group(_to_dev(ns->disk)->kobj,
On Mon, Aug 13, 2018 at 10:25:30AM -0700, Bart Van Assche wrote:
> This patch does not change the behavior of any existing code but
> introduces a function that will be used by the next patch.
"next" is hard to determine in a git log :)
Try being a bit more specific as to why you are doing this.
On Mon, 2018-08-13 at 20:42 +0200, Hannes Reinecke wrote:
> I have fixed the very same thing with my patchset titled "genhd:
> register default groups with device_add_disk" which is waiting for
> inclusion.
Thanks Hannes for the feedback. I will drop this patch series and review
your patches
On 08/13/2018 07:25 PM, Bart Van Assche wrote:
Hello Jens,
The two patches in this series fix a race condition related to the creation of
the sysfs attributes for the /dev/nvme0n devices nodes. I encountered this
race while adding tests to the blktests project for the NVMeOF kernel
drivers.
This patch does not change the behavior of any existing code but
introduces a function that will be used by the next patch.
Signed-off-by: Bart Van Assche
Cc: Keith Busch
Cc: Christoph Hellwig
Cc: Greg Kroah-Hartman
Cc: Sagi Grimberg
Cc: Matias Bjorling
Cc:
---
block/genhd.c | 26
For the udev rules that create symbolic links under /dev it is
essential that all sysfs attributes are registered before an object
becomes visible. This patch avoids that udevd fails to create the
/dev/disk/by-id/nvme-uuid.* symbolic link.
Fixes: 2b9b6e86bca7 ("NVMe: Export namespace attributes
Hello Jens,
The two patches in this series fix a race condition related to the creation of
the sysfs attributes for the /dev/nvme0n devices nodes. I encountered this
race while adding tests to the blktests project for the NVMeOF kernel
drivers. Please consider these patches for the upstream
On Mon, 2018-08-13 at 17:24 +0800, jianchao.wang wrote:
> I'm afraid this will not work.
Since this patch fixes a bug that nobody has reported so far and since no
later patches rely on this patch, I will leave it out.
Thanks,
Bart.
Hi Bart
On 08/11/2018 12:17 AM, Bart Van Assche wrote:
> void blk_pm_runtime_exit(struct request_queue *q)
> {
> if (!q->dev)
> return;
>
> pm_runtime_get_sync(q->dev);
> blk_freeze_queue(q);
> q->dev = NULL;
> blk_unfreeze_queue(q);
> }
I'm afraid
10 matches
Mail list logo
