Re: [PATCH v2] null_blk: Add conventional zone configuration for zoned support

2018-10-31 Thread Jens Axboe
On 10/30/18 1:14 AM, Masato Suzuki wrote: > Allow the creation of conventional zones by adding the zone_nr_conv > configuration attribute. This new attribute is used only for zoned devices > and indicates the number of conventional zones to create. The default value > is 0. Since host-managed

Re: [PATCH] block: brd: associate with queue until adding disk

2018-10-31 Thread Jens Axboe
On 10/31/18 2:40 AM, Ming Lei wrote: > brd_free() may be called in failure path on one brd instance which > disk isn't added yet, so release handler of gendisk may free the > associated request_queue early and causes the following use-after-free[1]. > > This patch fixes this issue by associating

Re: [PATCH] block: call rq_qos_exit() after queue is frozen

2018-10-31 Thread Jens Axboe
On 10/24/18 7:18 AM, Ming Lei wrote: > rq_qos_exit() removes the current q->rq_qos, this action has to be > done after queue is frozen, otherwise the IO queue path may never > be waken up, then IO hang is caused. > > So fixes this issue by moving rq_qos_exit() after queue is frozen. Looks good,

[PATCH] block: brd: associate with queue until adding disk

2018-10-31 Thread Ming Lei
brd_free() may be called in failure path on one brd instance which disk isn't added yet, so release handler of gendisk may free the associated request_queue early and causes the following use-after-free[1]. This patch fixes this issue by associating gendisk with request_queue just before adding