Re: [PATCH 01/33] block: add a lower-level bio_add_page interface

On May 10, 2018, at 12:40 AM, Christoph Hellwig wrote: > > On Wed, May 09, 2018 at 08:12:43AM -0700, Matthew Wilcox wrote: >> (page, len, off) is a bit weird to me. Usually we do (page, off, len). > > That's what I'd usually do, too. But this odd convention is what > bio_add_page

Re: EXT4 Oops (Re: [PATCH V15 06/22] mmc: block: Add blk-mq support)

On Mar 1, 2018, at 9:04 AM, Theodore Ts'o wrote: > This doesn't seem to make sense; the PC is where we are currently > executing, and LR is the "Link Register" where the flow of control > will be returning after the current function returns, right? Well, > dx_probe should *not*

Re: [PATCH v5 1/2] Return bytes transferred for partial direct I/O

On Jan 22, 2018, at 8:28 PM, Jens Axboe wrote: > > On 1/22/18 8:18 PM, Goldwyn Rodrigues wrote: >>> that their application was "already broken". I'd hate for a kernel >>> upgrade to break them. >>> >>> I do wish we could make the change, and maybe we can. But it probably >>>

Re: [PATCH v5 1/2] Return bytes transferred for partial direct I/O

> On Jan 20, 2018, at 8:07 PM, Jens Axboe wrote: > > On 1/20/18 7:23 PM, Goldwyn Rodrigues wrote: >> >> >> On 01/20/2018 08:11 PM, Andi Kleen wrote: >>> >>> It's likely there's a lot of code in user space that does >>> >>> if (write(..., N) < 0) handle error >>> >>>

Re: Ideas to reuse filesystem's checksum to enhance dm-raid1/10/5/6?

On Nov 15, 2017, at 7:18 PM, Qu Wenruo wrote: > > [Background] > Recently I'm considering the possibility to use checksum from filesystem > to enhance device-mapper raid. > > The idea behind it is quite simple, since most modern filesystems have > checksum for their

Re: [PATCH 9/9] nvme: add support for streams and directives

On Jun 26, 2017, at 7:56 AM, Jens Axboe wrote: > > On 06/26/2017 03:59 AM, Christoph Hellwig wrote: >> Looks mostly good, >> >> but two nit-picks: >> >> - can we keep a module option to disable streams, or in fact for >> now maybe to explicitly enable it? I expect this to

Re: [PATCHSET v2] Add support for write life time hints

On Jun 14, 2017, at 9:26 PM, Jens Axboe <ax...@kernel.dk> wrote: > On Wed, Jun 14, 2017 at 5:39 PM, Andreas Dilger <adil...@dilger.ca> wrote: >> On Jun 14, 2017, at 10:04 AM, Martin K. Petersen >> <martin.peter...@oracle.com> wrote: >>> Christoph, >&g

Re: [PATCHSET v2] Add support for write life time hints

On Jun 14, 2017, at 10:04 AM, Martin K. Petersen wrote: > Christoph, > >> I think what Martin wants (or at least what I'd want him to want) is >> to define a few REQ_* bits that mirror the RWF bits, use that to >> transfer the information down the stack, and then

Re: [PATCH 10/10] nvme: add support for streams and directives

On Jun 13, 2017, at 10:01 PM, Jens Axboe wrote: > > This adds support for Directives in NVMe, particular for the Streams > directive. Support for Directives is a new feature in NVMe 1.3. It > allows a user to pass in information about where to store the data, > so that it the

Re: [PATCH 02/10] blk-mq: expose stream write stats through debugfs

re that we don't race on updates. > > Signed-off-by: Jens Axboe <ax...@kernel.dk> Reviewed-by: Andreas Dilger <adil...@dilger.ca> > --- > block/blk-core.c | 5 + > block/blk-mq-debugfs.c | 24 > include/linux/blkdev.h | 3 +++ > 3 f

Re: [PATCH 04/10] fs: add support for allowing applications to pass in write life time hints

s to be relative to each other, no > absolute meaning should be attached to these flag names. > > Define IOCB flags to carry this information over, and finally > transform them into the block defined stream values. > > Signed-off-by: Jens Axboe <ax...@kernel.dk>

Re: [PATCH 0/11] Add support for write life time hints

On Jun 13, 2017, at 2:56 PM, Jens Axboe <ax...@kernel.dk> wrote: > > On 06/13/2017 02:45 PM, Andreas Dilger wrote: >>>>>> I thought that one of the major attractions of numeric stream IDs was >>>>>> that they had no semantic meanings, just &

Re: [PATCH 11/11] nvme: add support for streams and directives

On Jun 13, 2017, at 11:15 AM, Jens Axboe wrote: > This adds support for Directives in NVMe, particular for the Streams > directive. We default to allocating 4 streams per name space, but > it is configurable with the 'streams_per_ns' module option. > > If a write stream is set

Re: [PATCH 0/11] Add support for write life time hints

On Jun 13, 2017, at 2:13 PM, Jens Axboe <ax...@kernel.dk> wrote: > > On 06/13/2017 01:21 PM, Andreas Dilger wrote: >> On Jun 13, 2017, at 12:26 PM, Jens Axboe <ax...@kernel.dk> wrote: >>> >>> On 06/13/2017 12:04 PM, Andreas Dilger wrote: >>

Re: [PATCH 11/11] nvme: add support for streams and directives

On Jun 13, 2017, at 11:15 AM, Jens Axboe wrote: > > This adds support for Directives in NVMe, particular for the Streams > directive. We default to allocating 4 streams per name space, but > it is configurable with the 'streams_per_ns' module option. > > If a write stream is

Re: [PATCH 10/11] btrfs: add support for passing in stream information for buffered writes

On Jun 13, 2017, at 11:15 AM, Jens Axboe <ax...@kernel.dk> wrote: > > Signed-off-by: Jens Axboe <ax...@kernel.dk> Reviewed-by: Andreas Dilger <adil...@dilger.ca> > --- > fs/btrfs/extent_io.c | 1 + > fs/btrfs/inode.c | 1 + > 2 files changed, 2 inse

Re: [PATCH 09/11] xfs: add support for passing in stream information for buffered writes

On Jun 13, 2017, at 11:15 AM, Jens Axboe <ax...@kernel.dk> wrote: > > Signed-off-by: Jens Axboe <ax...@kernel.dk> Reviewed-by: Andreas Dilger <adil...@dilger.ca> > --- > fs/xfs/xfs_aops.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/xfs

Re: [PATCH 07/11] add support for buffered writeback to pass down stream information

On Jun 13, 2017, at 11:15 AM, Jens Axboe <ax...@kernel.dk> wrote: > > Signed-off-by: Jens Axboe <ax...@kernel.dk> Reviewed-by: Andreas Dilger <adil...@dilger.ca> > --- > fs/buffer.c | 14 +- > fs/mpage.c | 1 + > 2 files changed, 10 insertions(+),

Re: [PATCH 08/11] ext4: add support for passing in stream information for buffered writes

On Jun 13, 2017, at 11:15 AM, Jens Axboe <ax...@kernel.dk> wrote: > > Signed-off-by: Jens Axboe <ax...@kernel.dk> Reviewed-by: Andreas Dilger <adil...@dilger.ca> > --- > fs/ext4/page-io.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/ext

Re: [PATCH 06/11] fs: add O_DIRECT support for sending down bio stream information

> On Jun 13, 2017, at 11:15 AM, Jens Axboe <ax...@kernel.dk> wrote: > > Signed-off-by: Jens Axboe <ax...@kernel.dk> This patch is itself fine, if iocb_streamid() is fixed to pass the ID through without selecting only a single bit of the ID. Reviewed-by: Andreas Dilg

Re: [PATCH 05/11] add support for allowing applications to pass in write life time hints

On Jun 13, 2017, at 11:15 AM, Jens Axboe wrote: > > Add four flags for the pwritev2(2) system call, allowing an application > to give the kernel a hint about what on-media life times can be > expected from a given write. > > The intent is for these values to be relative to each

Re: [PATCH 04/11] add support for an inode to carry stream related data

s fine from the POV of passing the stream ID unchanged down the stack. If we really wanted to limit the ID to a 16-bit value, the i_stream could fit into a few 16-bit holes in struct inode, to avoid increasing its size. Reviewed-by: Andreas Dilger <adil...@dilger.ca> > --- > fs/inode.

Re: [PATCH 0/11] Add support for write life time hints

On Jun 13, 2017, at 12:26 PM, Jens Axboe <ax...@kernel.dk> wrote: > > On 06/13/2017 12:04 PM, Andreas Dilger wrote: >> On Jun 13, 2017, at 11:15 AM, Jens Axboe <ax...@kernel.dk> wrote: >>> >>> A new iteration of this patchset, previously known as writ

Re: [PATCH 03/11] blk-mq: expose stream write stats through debugfs

On Jun 13, 2017, at 11:15 AM, Jens Axboe wrote: > > Useful to verify that things are working the way they should. > Reading the file will return number of kb written to each > stream. Writing the file will reset the statistics. No care > is taken to ensure that we don't race on

Re: [PATCH 02/11] block: add definition for support data write life times

On Jun 13, 2017, at 11:15 AM, Jens Axboe wrote: > > Signed-off-by: Jens Axboe > --- > include/linux/blk_types.h | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index

Re: [PATCH 01/11] block: add support for carrying stream information in a bio

On Jun 13, 2017, at 11:15 AM, Jens Axboe <ax...@kernel.dk> wrote: > > No functional changes in this patch, but it allows each bio to > carry a stream ID and disallows merging of bio's with different > stream IDs. > > Signed-off-by: Jens Axboe <ax...@kernel.dk> Rev

Re: [PATCH 0/11] Add support for write life time hints

On Jun 13, 2017, at 11:15 AM, Jens Axboe wrote: > > A new iteration of this patchset, previously known as write streams. > Instead of exposing numeric values for streams, I've previously > advocated for just doing a set of hints that makes sense instead. See > the coverage from

Re: [LSF/MM TOPIC] do we really need PG_error at all?

On Feb 27, 2017, at 8:07 AM, Jeff Layton wrote: > > On Mon, 2017-02-27 at 11:27 +1100, NeilBrown wrote: >> On Sun, Feb 26 2017, James Bottomley wrote: >> >>> On Mon, 2017-02-27 at 08:03 +1100, NeilBrown wrote: On Sun, Feb 26 2017, James Bottomley wrote: >

Re: [PATCHv6 11/37] HACK: readahead: alloc huge pages, if allowed

On Feb 9, 2017, at 4:34 PM, Matthew Wilcox wrote: > > On Thu, Jan 26, 2017 at 02:57:53PM +0300, Kirill A. Shutemov wrote: >> Most page cache allocation happens via readahead (sync or async), so if >> we want to have significant number of huge pages in page cache we need >>

Re: [LSF/MM TOPIC] Badblocks checking/representation in filesystems

On Jan 17, 2017, at 3:15 PM, Andiry Xu wrote: > On Tue, Jan 17, 2017 at 1:35 PM, Vishal Verma > wrote: >> On 01/16, Darrick J. Wong wrote: >>> On Fri, Jan 13, 2017 at 05:49:10PM -0700, Vishal Verma wrote: On 01/14, Slava Dubeyko wrote: >

Re: [PATCHv4 18/43] block: define BIO_MAX_PAGES to HPAGE_PMD_NR if huge page cache enabled

On Oct 25, 2016, at 6:54 AM, Kirill A. Shutemov wrote: > > On Tue, Oct 25, 2016 at 12:21:22AM -0700, Christoph Hellwig wrote: >> On Tue, Oct 25, 2016 at 03:13:17AM +0300, Kirill A. Shutemov wrote: >>> We are going to do IO a huge page a time. So we need BIO_MAX_PAGES to be

Re: [PATCHv3 29/41] ext4: make ext4_mpage_readpages() hugepage-aware

On Sep 15, 2016, at 5:55 AM, Kirill A. Shutemov wrote: > > This patch modifies ext4_mpage_readpages() to deal with huge pages. > > We read out 2M at once, so we have to alloc (HPAGE_PMD_NR * > blocks_per_page) sector_t for that. I'm not entirely happy with

Re: [PATCHv2, 00/41] ext4: support of huge pages

On Aug 12, 2016, at 12:37 PM, Kirill A. Shutemov wrote: > > Here's stabilized version of my patchset which intended to bring huge pages > to ext4. > > The basics are the same as with tmpfs[1] which is in Linus' tree now and > ext4 built on top of it. The main