asks + curvec, irq_default_affinity);
> - free_node_to_present_cpumask(node_to_present_cpumask);
> + free_node_to_possible_cpumask(node_to_possible_cpumask);
> out:
> free_cpumask_var(nmsk);
> return masks;
> @@ -214,7 +214,7 @@ int irq_calc_affinity_vectors(
\
> mutex_lock(&(ca)->set->bucket_lock);\
>
_Actually_ there is a push to remove all kthreads in the kernel, as they
don't play nice together with RT.
So while you're at it, do you think it'd be possible to convert
ic inline void blk_queue_bounce(struct request_queue
> *q, struct bio **bio)
> }
> #endif /* CONFIG_BOUNCE */
>
> +extern void blk_drain_queue(struct request_queue *q);
> +
> #endif /* BLK_INTERNAL_H */
>
I seem to have missed something.
Is blk_drain_queue() ever used?
Chee
---
> drivers/nvme/host/multipath.c | 6 +
> drivers/nvme/host/nvme.h | 1 +
> 3 files changed, 38 insertions(+), 26 deletions(-)
>
In principle, yes, but I would like to have some more info (like
subsysnqn, and maybe 'model' etc) in the subsys sysfs entry, too.
But this
files changed, 440 insertions(+), 15 deletions(-)
> create mode 100644 drivers/nvme/host/multipath.c
>
After much discussion I'm finally fine with this.
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
into breaking things out, so that the nvme code just
creates the symlinks and the block-device claiming code honours the
'HIDDEN' flag.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX Gm
his week
And I'll see to get the other patches reviewed.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild,
si/pmcraid.h | 2 +-
> 3 files changed, 6 insertions(+), 40 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX G
vindranath <anil_ravindran...@pmc-sierra.com>
> ---
> drivers/scsi/pmcraid.h | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
oph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Sagi Grimberg <s...@grimberg.me>
> ---
> drivers/target/Kconfig | 1 +
> drivers/target/target_core_transport.c | 46
> +++---
> 2 files changed
On 10/30/2017 10:01 PM, Brian King wrote:
> On 10/30/2017 03:37 PM, Bart Van Assche wrote:
>> On Wed, 2017-10-18 at 15:57 -0500, Brian King wrote:
>>> On 10/17/2017 01:19 AM, Hannes Reinecke wrote:
>>>> On 10/17/2017 12:49 AM, Bart Van Assche wrote:
&g
vers, namely refer from the higher
> layers to the lower layer instead of from the lower layer to the
> higher layers.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.de&
e), but we simply
cannot declare nvme multipathing being the one true way for NVMe.
The support-calls alone will kill us.
Note: this has _nothing_ to do with performance. I'm perfectly fine to
accept that dm-multipath has sub-optimal performance.
But that should not imply that it cannot
_ns_id_attr_group))
> pr_warn("%s: failed to create sysfs group for identification\n",
> ns->disk->disk_name);
> if (ns->ndev && nvme_nvm_register_sysfs(ns))
> pr_warn("%s: failed to register light
req_needs_retry() checks blk_noretry_request():
static inline bool nvme_req_needs_retry(struct request *req)
{
if (blk_noretry_request(req))
return false;
which has:
#define blk_noretry_request(rq) \
((rq)->cmd_flags & (REQ_FAILFAST_DEV|REQ_FAILFAS
ed-by: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> drivers/nvme/host/core.c | 190
> +--
> drivers/nvme/host/lightnvm.c | 14 ++--
> drivers/nvme/host/nvme.h | 21 -
> 3 files changed, 190 insertions(+), 35 delet
gt; return -EWOULDBLOCK;
> file->private_data = ctrl;
> return 0;
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 7
de>
> ---
> drivers/nvme/host/core.c | 76
> ++--
> drivers/nvme/host/nvme.h | 3 +-
> 2 files changed, 18 insertions(+), 61 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storag
target/loop.c | 2 +-
> 6 files changed, 39 insertions(+), 33 deletions(-)
> Round of applause for this :-)
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
lst.de>
> Reviewed-by: Sagi Grimberg <s...@grimberg.me>
> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> drivers/nvme/host/core.c | 40 ++--
> 1 file changed, 10 insertions(+), 30 deletions(-)
>
Reviewed-by: Hann
_unless_zero in this function.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> Reviewed-by: Sagi Grimberg <s...@grimberg.me>
> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> drivers/nvme/host/core.c | 3 ++-
> 1 file changed, 2 insertions(+
.c | 2 +-
> 8 files changed, 25 insertions(+), 16 deletions(-)
> Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE
ut if a gendisk is
hidden? I'd hate having to do an inverse lookup in /proc/partitions;
it's always hard to prove that something is _not_ present.
And we already present various information (like disk_removable_show()),
so it's not without precedent.
And it would make integration with systemd/ud
t; 2 files changed, 1 insertion(+), 5 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5
;
> ---
> block/blk-core.c | 20
> include/linux/blkdev.h | 2 ++
> 2 files changed, 22 insertions(+)
> Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
ristoph Hellwig <h...@lst.de>
> Reviewed-by: Sagi Grimberg <s...@grimberg.me>
> ---
> block/blk-core.c | 34 ++
> include/linux/blkdev.h | 1 +
> 2 files changed, 35 insertions(+)
>
Reviewed-by: Hannes Reinecke <h...@su
has even
> explained a reason for it.
I wonder what has changed ...
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
gt; 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 904
gt; 1 file changed, 5 insertions(+)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer
On 10/17/2017 10:18 PM, Bart Van Assche wrote:
> On Tue, 2017-10-17 at 08:33 +0200, Hannes Reinecke wrote:
>> How do you ensure that PREEMPT requests are not stuck in the queue
>> _behind_ non-PREEMPT requests?
>> Once they are in the queue the request are already allocated
On 10/17/2017 03:29 AM, Ming Lei wrote:
> On Mon, Oct 16, 2017 at 01:30:09PM +0200, Hannes Reinecke wrote:
>> On 10/13/2017 07:29 PM, Ming Lei wrote:
>>> On Fri, Oct 13, 2017 at 05:08:52PM +, Bart Van Assche wrote:
>>>> On Sat, 2017-10-14 at 00:45 +0800, Ming L
e for sparse to verify this.
> This patch does not change any functionality.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com>
> Cc: linux-n...@lists.infradead.org
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Joh
-
> Changes compared to v1:
> - Removed "Cc: "
> - Removed "bug fix" from the description.
>
> block/blk-mq.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.c
never ever scheduled during quiesce.
How do you avoid such a scenario?
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
he <bart.vanass...@wdc.com>
> Tested-by: Martin Steigerwald <mar...@lichtvoll.de>
> Cc: Ming Lei <ming@redhat.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Johannes Thumshirn <jthumsh...@suse.de>
> ---
&
g <h...@lst.de>
> Cc: Ming Lei <ming@redhat.com>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> block/blk-core.c | 4 +++-
> block/blk-mq.c | 2 ++
> include/linux/blk-mq.h | 1 +
> 3 fi
@wdc.com>
> Tested-by: Martin Steigerwald <mar...@lichtvoll.de>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Ming Lei <ming@redhat.com>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Johannes Thumshi
gt;
> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
> Tested-by: Martin Steigerwald <mar...@lichtvoll.de>
> Cc: Ming Lei <ming@redhat.com>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> block/blk-core.c | 12
> block/blk-mq.c |
dc.com>
> Reviewed-by: Shaohua Li <s...@kernel.org>
> Tested-by: Martin Steigerwald <mar...@lichtvoll.de>
> Cc: linux-r...@vger.kernel.org
> Cc: Ming Lei <ming....@redhat.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@s
y: Shaohua Li <s...@kernel.org>
> Tested-by: Martin Steigerwald <mar...@lichtvoll.de>
> Cc: linux-r...@vger.kernel.org
> Cc: Ming Lei <ming@redhat.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> drivers/md/m
d-by: Johannes Thumshirn <jthumsh...@suse.de>
> Reviewed-by: Shaohua Li <s...@kernel.org>
> Tested-by: Martin Steigerwald <mar...@lichtvoll.de>
> Cc: linux-r...@vger.kernel.org
> Cc: Ming Lei <ming@redhat.com>
> Cc: Christoph Hellwig <h...@lst.de&g
RNEL | GFP_DMA | __GFP_ZERO, >num_sg);
>
> return sglist;
> }
> diff --git a/drivers/scsi/pmcraid.h b/drivers/scsi/pmcraid.h
> index 44da91712115..754ef30927e2 100644
> --- a/drivers/scsi/pmcraid.h
> +++ b/drivers/scsi/pmcraid.h
> @@ -542,7 +542,7 @@ struct pmcraid_sg
at
the code, those two drivers look awfully similar ...).
pmcraid_sglist looks as if it's a hardware-dependent structure, so just
removing one entry from the middle of a structure might not be a good idea.
But this is something for the pmcraid folks to clarify.
Cheers,
a/drivers/scsi/ipr.h
> +++ b/drivers/scsi/ipr.h
> @@ -1454,7 +1454,7 @@ struct ipr_sglist {
> u32 num_sg;
> u32 num_dma_sg;
> u32 buffer_len;
> - struct scatterlist scatterlist[1];
> + struct scatterlist *scatterlist;
> };
>
> enum
oph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
> Cc: Sagi Grimberg <s...@grimberg.me>
> ---
> drivers/target/Kconfig | 1 +
> drivers/target/target_core_transport.c | 46
> +++---
> 2 files chang
h <keith.bu...@intel.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Sagi Grimberg <s...@grimberg.me>
> ---
> drivers/nvme/target/Kconfig | 1 +
> drivers/nvme/target/rdma.c | 63
> +++--
> 2 files changed
---
> 2 files changed, 3 insertions(+), 34 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfel
u <herb...@gondor.apana.org.au>
> ---
> crypto/Kconfig | 1 +
> crypto/scompress.c | 51 ++-
> 2 files changed, 3 insertions(+), 49 deletions(-)
> Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hanne
++
> lib/Kconfig | 4 ++
> lib/scatterlist.c | 105
>
> 3 files changed, 119 insertions(+)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinec
e value?
>
> ->can_queue is size of the whole tag space shared by all LUNs, looks it isn't
> reasonable to increase cmd_per_lun to .can_queue.
>
'3' is just a starting point; later on it'll be adjusted via
scsi_change_depth().
Looks like it's not working correctly with blk-mq, though.
disk as cached device, and 1TB SSD as cache device,
> and set fio to write 500G dirty data in total. Is this configuration
> close to the working set and cache size you suggested ?
>
Weell, for a realistic scenario you should be aiming for having about
one order of magnitude difference between
t's not that Coly is deliberately
blocking your patches, it's just that he doesn't see the performance
benefit on his side.
Might be that he's using the wrong parameters, but than that should be
clarified once the fio script is posted.
At the same time I don't think that the size of the dataset is
inux/bsg.h | 35 --
> 7 files changed, 251 insertions(+), 211 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49
---
> include/linux/bsg-lib.h | 1 -
> 2 files changed, 6 insertions(+), 9 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 9
; ---
> block/bsg-lib.c | 1 +
> drivers/s390/scsi/zfcp_fc.c | 4 ++--
> include/linux/bsg-lib.h | 2 ++
> 3 files changed, 5 insertions(+), 2 deletions(-)
> Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke
+-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nür
t; + bsg_reply->result = -ENXIO;
> return 0;
>
> done:
Whitespace issue ...
Otherwise:
Reviwed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
On 10/03/2017 12:48 PM, Christoph Hellwig wrote:
> bsg_job_done takes care of updating the scsi_request structure fields.
>
> Signed-off-by: Christoph Hellwig <h...@lst.de>
> ---
> drivers/scsi/libfc/fc_lport.c | 3 ---
> 1 file changed, 3 deletions(-)
>
Revi
ig <h...@lst.de>
> ---
> drivers/scsi/bfa/bfad_bsg.c | 7 ---
> 1 file changed, 7 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
ed-off-by: Benjamin Block <bbl...@linux.vnet.ibm.com>
> ---
> block/bsg-lib.c | 27 +--
> 1 file changed, 21 insertions(+), 6 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTe
cked MD?
It's using kernel threads, which probably should be stopped, too, when
going into suspend. After all, MD might be doing on of it's internal
operations (eg resync) at that time, which will generate quite some I/O.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Netw
SYSTEMD_READY=0'
whenever this setting is detected, and the entire udev mechanism will
leave it alone.
Once this is done we have the paths nicely separated in udev, and then
setting up the symlinks pointing to the correct device is trivial.
Cheers,
Hannes
--
Dr. Hannes ReineckeTe
a customer
report running into a q_usage_counter underflow with legacy-sq.
So this patch is actually a bugfix.
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
ds freezable.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com>
> Cc: Shaohua Li <s...@kernel.org>
> Cc: linux-r...@vger.kernel.org
> Cc: Ming Lei <ming@redhat.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.com>
&g
ng Lei <ming@redhat.com>
> [ bvanassche: Combined two patches into one, edited a comment and made sure
> REQ_NOWAIT is handled properly in blk_old_get_request() ]
> Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com>
> Cc: Ming Lei <ming@redhat.com>
>
On 09/25/2017 03:50 PM, Christoph Hellwig wrote:
> On Mon, Sep 25, 2017 at 03:47:43PM +0200, Hannes Reinecke wrote:
>> Can't we make the multipath support invisible to the host?
>> IE check the shared namespaces before creating the device node, and just
>> move them under th
?
Thing is, this device multiplication was (and is) the #1 objection to
dm-multipath, and we should be looking to avoid that if we do a new
implementation.
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911
| 12 +
> block/Makefile| 1 +
> block/zoned-iosched.c | 925
> ++
> 4 files changed, 986 insertions(+)
> create mode 100644 Documentation/block/zoned-iosched.txt
> create mode 100644 block/zon
drivers/scsi/sd_zbc.c | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053
nsertions(+), 8 deletions(-)
>
Reviwed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imend
; ---
> drivers/scsi/sd_zbc.c | 119
> +++---
> 1 file changed, 114 insertions(+), 5 deletions(-)
>
I would've been slightly worried about locking; these things tend to be
reset during revalidate, which happens quite frequently for ATA drives.
You sure you don
t-managed */
> sdkp->urswrz = buf[4] & 1;
> sdkp->zones_optimal_open = 0;
> sdkp->zones_optimal_nonseq = 0;
> - sdkp->zones_max_open = get_unaligned_be64([16]);
> + sdkp->zones_max_open = get_unalign
e is introduced by this patch.
>
> Signed-off-by: Damien Le Moal <damien.lem...@wdc.com>
> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> drivers/scsi/sd_zbc.c | 12
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
Reviewed-by: Hannes
No functional change is introduced by this patch.
>
> Signed-off-by: Damien Le Moal <damien.lem...@wdc.com>
> ---
> drivers/scsi/sd_zbc.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Han
>
Actually you should've used kernel-doc style to format the comments;
just to keep the 0-day bot happy
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5,
lementations depending on which subsystem
is being used.
Which really is a maintenance nightmare.
I'm not averse to having other multipath implementations in the kernel,
but it really should be abstracted so that other subsystems can _try_ to
leverage it.
Cheers,
Hannes
--
Dr. Hannes Reinecke
> ---
> drivers/block/loop.c | 76
>
> 1 file changed, 11 insertions(+), 65 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
> +++ b/include/uapi/linux/loop.h
> @@ -88,6 +88,7 @@ struct loop_info64 {
> #define LOOP_CHANGE_FD 0x4C06
> #define LOOP_SET_CAPACITY0x4C07
> #define LOOP_SET_DIRECT_IO 0x4C08
> +#define LOOP_SET_BLOCK_SIZE 0x4C09
>
> /* /d
> lo->lo_queue->queuedata = lo;
>
> + blk_queue_physical_block_size(lo->lo_queue, PAGE_SIZE);
> +
> /*
>* It doesn't make sense to enable merge because the I/O
>* submitted to backing file is handled page by page.
>
Let's see it
---
> drivers/block/loop.c | 10 ++
> drivers/block/loop.h | 1 -
> 2 files changed, 2 insertions(+), 9 deletions(-)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
.
>
> I think that's a good idea, there was already too much late churn
> fixing up the 4k support. Dropped the fixups, added this.
>
I'll never get it upstream ...
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
EPTH if and only if
> q->queue_depth != 0. Wouldn't it be better to let the block driver tell the
> block layer whether or not there is a queue depth limit across hardware
> queues, e.g. through a tag set flag?
>
Yes, please.
I've come across this several times now, and am alw
+ blk_queue_max_discard_sectors(q, UINT_MAX >> 9);
> + blk_queue_max_write_zeroes_sectors(q, UINT_MAX >> 9);
> queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, q);
> }
>
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reineck
---
> drivers/block/loop.c | 44 ++--
> drivers/block/loop.h | 1 -
> 2 files changed, 18 insertions(+), 27 deletions(-)
>
Curiously enough, this is what I attempted initially.
But that got shut down due to incompability.
In the hope that you'll succeed:
Reviewed-by: Han
key, lo->lo_encrypt_key,
> lo->lo_encrypt_key_size);
> }
> + LO_INFO_BLOCKSIZE(info) = queue_logical_block_size(lo->lo_queue);
> return 0;
> }
>
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes
On 08/18/2017 10:05 AM, Omar Sandoval wrote:
> On Fri, Aug 18, 2017 at 09:56:26AM +0200, Hannes Reinecke wrote:
>> On 08/18/2017 09:47 AM, Omar Sandoval wrote:
[ .. ]
>>>
>>> I actually checked losetup, it works just fine with LO_FLAGS_BLOCKSIZE
>>> alw
On 08/18/2017 09:47 AM, Omar Sandoval wrote:
> On Fri, Aug 18, 2017 at 09:43:19AM +0200, Hannes Reinecke wrote:
>> On 08/18/2017 09:38 AM, Omar Sandoval wrote:
>>> On Fri, Aug 18, 2017 at 09:18:52AM +0200, Hannes Reinecke wrote:
[ .. ]
>>>> I've got quite some fla
On 08/18/2017 09:38 AM, Omar Sandoval wrote:
> On Fri, Aug 18, 2017 at 09:18:52AM +0200, Hannes Reinecke wrote:
>> On 08/18/2017 08:15 AM, Omar Sandoval wrote:
>>> From: Omar Sandoval <osan...@fb.com>
>>>
>>> When I was writing a test for the new l
> - /* fall through if not online */
> + /* fall through */
> + /* if not online */
> case XenbusStateUnknown:
> /* implies xen_blkif_disconnect() via xen_blkbk_remove() */
> device_unregister(>dev);
>
is_scsi(req))
> err = virtblk_add_req_scsi(vblk->vqs[qid].vq, vbr, vbr->sg,
> num);
> else
> err = virtblk_add_req(vblk->vqs[qid].vq, vbr, vbr->sg, num);
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hann
count;
> }
>
> static void xen_blkbk_unmap_and_respond_callback(int result, struct
> gntab_unmap_queue_data *data)
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de
uptodate = 1; /* FIXME */
> else if (pc->c[0] == GPCMD_REQUEST_SENSE) {
>
>
Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de +49 91
mbol-to-text translation tables.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com>
> Cc: Omar Sandoval <osan...@fb.com>
> Cc: Hannes Reinecke <h...@suse.com>
> ---
> block/.gitignore | 1 +
> block/Makefile | 58 +++
*file)
> return seq_release(inode, file);
> }
>
> -const struct file_operations blk_mq_debugfs_fops = {
> +static const struct file_operations blk_mq_debugfs_fops = {
> .open = blk_mq_debugfs_open,
> .read = seq_read,
> .write
m.com>
> Cc: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> block/blk-mq-tag.c | 9 +
> drivers/nvme/host/fc.c | 4 +---
> drivers/nvme/host/rdma.c | 11 ++-
> include/linux/blk-mq.h | 5 ++---
> 4 files changed, 14 insertions(+), 15 del
llwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.de>
> Cc: Johannes Thumshirn <jthumsh...@suse.de>
> ---
> block/blk-mq.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index f84d145490bf..b86d2cafc35
On 08/18/2017 01:23 AM, Bart Van Assche wrote:
> This function is only used inside the block layer core. Hence
> unexport it.
>
> Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hannes Reinecke <h...@suse.de&g
; Fixes: commit 39a70c76b89b ("blk-mq: clarify dispatch may not be
> drained/blocked by stopping queue")
> Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com>
> Cc: Ming Lei <ming@redhat.com>
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Hann
err = -EINVAL;
> + goto exit;
> + }
> + if (lo_logical_blocksize > lo->lo_blocksize) {
> + err = -EINVAL;
> + goto exit;
> + }
> } else {
> lo_logical_bl
attributes will only change if the 'LO_FLAGS_BLOCKSIZE'
flag has been set
and
c) validate the written blocksizes; this is required to be able to
install bootloaders there
This whole interface was designed such that you can prepare bootable
diskimages for S/390 DASDs, which use a native 4k blocks
201 - 300 of 561 matches
Mail list logo
