Re: [PATCH 2/2] zram: do not count duplicated pages as compressed

2017-05-21 Thread Minchan Kim
On Sun, May 21, 2017 at 12:04:27AM -0700, Christoph Hellwig wrote: > On Wed, May 17, 2017 at 05:32:12PM +0900, Minchan Kim wrote: > > Is block device(esp, zram which is compressed ram block device) okay to > > return garbage when ongoing overwrite IO fails? > > > >

Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses

2017-04-02 Thread Minchan Kim
Hi Jens, On Thu, Mar 30, 2017 at 07:38:26PM -0600, Jens Axboe wrote: > On 03/30/2017 05:45 PM, Minchan Kim wrote: > > On Thu, Mar 30, 2017 at 09:35:56AM -0600, Jens Axboe wrote: > >> On 03/30/2017 09:08 AM, Minchan Kim wrote: > >>> Hi Jens, > >>> >

Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses

2017-03-30 Thread Minchan Kim
Hi Jens, It seems you miss this. Could you handle this? Thanks. On Thu, Mar 9, 2017 at 2:28 PM, Minchan Kim <minc...@kernel.org> wrote: < snip> > Jens, Could you replace the one merged with this? And I don't want > to add stable mark in this patch because I feel it nee

[PATCH] block: do not put mq context in blk_mq_alloc_request_hctx

2017-03-29 Thread Minchan Kim
com> Signed-off-by: Minchan Kim <minc...@kernel.org> --- Maybe, it would be fixed by someone but I have noticed preempt counter undeflow problem a few weeks ago and still see the problem with linux-next. block/blk-mq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/blk-mq.

Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses

2017-03-08 Thread Minchan Kim
On Wed, Mar 08, 2017 at 08:58:02AM +0100, Johannes Thumshirn wrote: > On 03/08/2017 06:11 AM, Minchan Kim wrote: > > And could you test this patch? It avoids split bio so no need new bio > > allocations and makes zram code simple. > > > > From f778d7564d5cd772f25bb181

[RFC] blk: increase logical_block_size to unsigned int

2017-01-08 Thread Minchan Kim
overflow in logical block size [2] 924bd88d703e, zram: allow partial page operations Cc: Sergey Senozhatsky <sergey.senozhat...@gmail.com> Cc: Jens Axboe <ax...@kernel.dk> Cc: Robert Jennings <r...@linux.vnet.ibm.com> Cc: Jerome Marchand <jmarc...@redhat.com> Signed-off-by

Re: [PATCH 2/3] zram: support page-based parallel write

2016-10-16 Thread Minchan Kim
Hi Sergey, On Fri, Oct 07, 2016 at 03:33:22PM +0900, Minchan Kim wrote: < snip > > > so the question is -- can we move this parallelization out of zram > > and instead flush bdi in more than one kthread? how bad that would > > be? can anyone else benefit from this?

Re: [PATCH 2/3] zram: support page-based parallel write

2016-10-07 Thread Minchan Kim
Hi Sergey, On Thu, Oct 06, 2016 at 05:29:15PM +0900, Sergey Senozhatsky wrote: > Hello Minchan, > > On (10/05/16 11:01), Minchan Kim wrote: > [..] > > 1. just changed ordering of test execution - hope to reduce testing time > > due to > >block population befor

Re: [PATCH 2/3] zram: support page-based parallel write

2016-10-04 Thread Minchan Kim
Hi Sergey, On Tue, Oct 04, 2016 at 01:43:14PM +0900, Sergey Senozhatsky wrote: < snip > > TEST > > > new tests results; same tests, same conditions, same .config. > 4-way test: > - BASE zram, fio direct=1 > - BASE zram, fio fsync_on_close=1 > - NEW zram, fio direct=1 > - NEW zram, fio

Re: [PATCH 2/3] zram: support page-based parallel write

2016-10-04 Thread Minchan Kim
, I didn't know we have block-dev mailing list. > > > On (09/22/16 15:42), Minchan Kim wrote: > : zram supports stream-based parallel compression. IOW, it can support > : parallel compression on SMP system only if each cpus has streams. > : For example, assuming 4 CPU system,