Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

On 28/02/18 19:38, Boaz Harrosh wrote: <> > Based on v4.15 code feel free to add to your patchset > where needed > Sorry is what happens when you work on so many Linux versions at the same time. This one is based on v4.15 > > Don't leak the request if blk_rq_append_bio fails > >

Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

On 27/02/18 16:44, Jiri Palecek wrote: <> >> These are BIDI commands that travel as a couple of chained requests. They are >> sent as BLOCK_PC command and complete or fail as one hole unit. The system >> is not >> allowed (And does not know how) to split them or complete them partially. >> This

Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

On 21/02/18 18:20, Boaz Harrosh wrote: <> > again not followed closely but if it is about the free of the bounce buffers > then I would just disable bouncing for osd all together. There are only a very > few (2) drivers that support bidi for osd. iscsi and iser so we know those are > totally cool

Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

On 20/02/18 17:21, Jiri Palecek wrote: > Hello, > > I had a look at the callers of blk_rq_append_bio and checked the > callers. Some changes may need to be done there and I'd like the input > of their maintainers as well before finalising the patch. > > Ming Lei writes: >

Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

Hello, I had a look at the callers of blk_rq_append_bio and checked the callers. Some changes may need to be done there and I'd like the input of their maintainers as well before finalising the patch. Ming Lei writes: > On Tue, Jan 30, 2018 at 04:24:14PM +0100, Jiri

Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

On 1/31/18 6:24 AM, Ming Lei wrote: On Tue, Jan 30, 2018 at 04:24:14PM +0100, Jiri Palecek wrote: On 1/30/18 1:53 PM, Ming Lei wrote: On Thu, Jan 25, 2018 at 9:58 PM, Jiří Paleček wrote: Avoids page leak from bounced requests --- block/blk-map.c | 3 ++- 1 file

Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

On Tue, Jan 30, 2018 at 04:24:14PM +0100, Jiri Palecek wrote: > > On 1/30/18 1:53 PM, Ming Lei wrote: > > On Thu, Jan 25, 2018 at 9:58 PM, Jiří Paleček wrote: > > > Avoids page leak from bounced requests > > > --- > > > block/blk-map.c | 3 ++- > > > 1 file changed, 2

Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

On 1/30/18 1:53 PM, Ming Lei wrote: On Thu, Jan 25, 2018 at 9:58 PM, Jiří Paleček wrote: Avoids page leak from bounced requests --- block/blk-map.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/blk-map.c b/block/blk-map.c index

Re: [PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

On Thu, Jan 25, 2018 at 9:58 PM, Jiří Paleček wrote: > Avoids page leak from bounced requests > --- > block/blk-map.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/block/blk-map.c b/block/blk-map.c > index d3a94719f03f..702d68166689 100644 > ---

[PATCH] Use bio_endio instead of bio_put in error path of blk_rq_append_bio

Avoids page leak from bounced requests --- block/blk-map.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/blk-map.c b/block/blk-map.c index d3a94719f03f..702d68166689 100644 --- a/block/blk-map.c +++ b/block/blk-map.c @@ -26,7 +26,8 @@ int blk_rq_append_bio(struct