Re: [PATCH] bcache: don't attach backing with duplicate UUID

2018-03-05 Thread Michael Lyle
Hi Tang Junhui--- Thanks for your review. I just sent it upstream (with your change) to Jens. Mike On 03/04/2018 05:07 PM, tang.jun...@zte.com.cn wrote: > Hello Mike > > I send the email from my personal mailbox(110950...@qq.com), it may be fail, > so I resend this email from my office

Re: [PATCH] bcache: don't attach backing with duplicate UUID

2018-03-04 Thread tang . junhui
Hello Mike I send the email from my personal mailbox(110950...@qq.com), it may be fail, so I resend this email from my office mailbox again. bellow is the mail context I send previous. I am Tang Junhui(tang.jun...@zte.com.cn), This email

Re: [PATCH] bcache: don't attach backing with duplicate UUID

2018-03-02 Thread Michael Lyle
On 03/02/2018 06:55 AM, Michael Lyle wrote: > Hi Tang Junhui--- > > On 03/01/2018 09:45 PM, tang.jun...@zte.com.cn wrote: >> From: Tang Junhui >> >> Hello, Mike >> >> This patch looks good, but has some conflicts with this patch: >> bcache: fix for data collapse after

Re: [PATCH] bcache: don't attach backing with duplicate UUID

2018-03-02 Thread Michael Lyle
Hi Tang Junhui--- On 03/01/2018 09:45 PM, tang.jun...@zte.com.cn wrote: > From: Tang Junhui > > Hello, Mike > > This patch looks good, but has some conflicts with this patch: > bcache: fix for data collapse after re-attaching an attached device >

Re: [PATCH] bcache: don't attach backing with duplicate UUID

2018-03-01 Thread tang . junhui
From: Tang Junhui Hello, Mike This patch looks good, but has some conflicts with this patch: bcache: fix for data collapse after re-attaching an attached device

[PATCH] bcache: don't attach backing with duplicate UUID

2018-03-01 Thread Michael Lyle
This can happen e.g. during disk cloning. This is an incomplete fix: it does not catch duplicate UUIDs earlier when things are still unattached. It does not unregister the device. Further changes to cope better with this are planned but conflict with Coly's ongoing improvements to handling