Re: [PATCH] blk-iolatency: fix max_depth comparisons

2018-07-11 Thread Jens Axboe
On 7/11/18 8:28 AM, Josef Bacik wrote: > On Wed, Jul 11, 2018 at 08:22:28AM -0600, Jens Axboe wrote: >> On 7/11/18 7:30 AM, Josef Bacik wrote: >>> max_depth used to be a u64, but I changed it to a unsigned int but >>> didn't convert my comparisons over everywhere. Fix by comparing to >>> INT_MAX

Re: [PATCH] blk-iolatency: fix max_depth comparisons

2018-07-11 Thread Josef Bacik
On Wed, Jul 11, 2018 at 08:22:28AM -0600, Jens Axboe wrote: > On 7/11/18 7:30 AM, Josef Bacik wrote: > > max_depth used to be a u64, but I changed it to a unsigned int but > > didn't convert my comparisons over everywhere. Fix by comparing to > > INT_MAX instead of (u64)-1. > > Should that be

Re: [PATCH] blk-iolatency: fix max_depth comparisons

2018-07-11 Thread Jens Axboe
On 7/11/18 7:30 AM, Josef Bacik wrote: > max_depth used to be a u64, but I changed it to a unsigned int but > didn't convert my comparisons over everywhere. Fix by comparing to > INT_MAX instead of (u64)-1. Should that be UINT_MAX? -- Jens Axboe

[PATCH] blk-iolatency: fix max_depth comparisons

2018-07-11 Thread Josef Bacik
max_depth used to be a u64, but I changed it to a unsigned int but didn't convert my comparisons over everywhere. Fix by comparing to INT_MAX instead of (u64)-1. Reported-by: Dan Carpenter Signed-off-by: Josef Bacik --- block/blk-iolatency.c | 4 ++-- 1 file changed, 2 insertions(+), 2