Re: [PATCH] blk-mq: remove unused function hctx_allow_merges

2017-09-30 Thread Jens Axboe
On 09/30/2017 10:15 AM, Jens Axboe wrote: > On 09/30/2017 09:01 AM, weiping zhang wrote: >> since 9bddeb2a5b981 "blk-mq: make per-sw-queue bio merge as default >> .bio_merge" >> there is no caller for this function. > > Looks like this should change the new check to actually use this function >

Re: [PATCH] blk-mq: remove unused function hctx_allow_merges

2017-09-30 Thread Jens Axboe
On 09/30/2017 09:01 AM, weiping zhang wrote: > since 9bddeb2a5b981 "blk-mq: make per-sw-queue bio merge as default > .bio_merge" > there is no caller for this function. Looks like this should change the new check to actually use this function instead, or we will be doing merges if someone has

Re: [PATCH] blk-mq: remove unused function hctx_allow_merges

2017-09-30 Thread Ming Lei
On Sat, Sep 30, 2017 at 3:01 PM, weiping zhang wrote: > since 9bddeb2a5b981 "blk-mq: make per-sw-queue bio merge as default > .bio_merge" > there is no caller for this function. > > Signed-off-by: weiping zhang Reviewed-by: Ming Lei

[PATCH] blk-mq: remove unused function hctx_allow_merges

2017-09-30 Thread weiping zhang
since 9bddeb2a5b981 "blk-mq: make per-sw-queue bio merge as default .bio_merge" there is no caller for this function. Signed-off-by: weiping zhang --- block/blk-mq.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index