Re: [PATCH] blk-throttle: fix infinite throttling caused by non-cascading timer wheel

2016-09-27 Thread Vivek Goyal
On Mon, Sep 19, 2016 at 03:11:10PM -0600, Jens Axboe wrote: > On 09/19/2016 03:06 PM, Vivek Goyal wrote: > > On Tue, Sep 13, 2016 at 09:46:46AM -0400, Vivek Goyal wrote: > > > > > > Hi Hou Tao, > > > > > > [ CC Tejun and Thomas ] > > > > > > Thanks for the patch. I can reproduce it. I am

Re: [PATCH] blk-throttle: fix infinite throttling caused by non-cascading timer wheel

2016-09-19 Thread Jens Axboe
On 09/19/2016 03:06 PM, Vivek Goyal wrote: On Tue, Sep 13, 2016 at 09:46:46AM -0400, Vivek Goyal wrote: Hi Hou Tao, [ CC Tejun and Thomas ] Thanks for the patch. I can reproduce it. I am wondering that why are you doing so many checks. Can't we just check if throttle group is empty or not.

Re: [PATCH] blk-throttle: fix infinite throttling caused by non-cascading timer wheel

2016-09-13 Thread Vivek Goyal
On Mon, Sep 12, 2016 at 02:45:30PM +0800, Hou Tao wrote: > Due to commit 500462a9de65 ("timers: Switch to a non-cascading wheel"), > the slack of timer increases when the timeout increases: > > So for HZ=250 we end up with the following granularity levels: > Level Offset Granularity

[PATCH] blk-throttle: fix infinite throttling caused by non-cascading timer wheel

2016-09-12 Thread Hou Tao
Due to commit 500462a9de65 ("timers: Switch to a non-cascading wheel"), the slack of timer increases when the timeout increases: So for HZ=250 we end up with the following granularity levels: Level Offset Granularity Range 0 0 4 ms 0 ms -