On 9/15/18 1:03 AM, Christoph Hellwig wrote:
> On Wed, Sep 05, 2018 at 11:33:35AM +0800, Ming Lei wrote:
>> It is pointed that bio_rewind_iter() is one very bad API[1]:
>>
>> 1) bio size may not be restored after rewinding
>>
>> 2) it causes some bogus change, such as 5151842b9d8732 (block: reset
>
On Wed, Sep 05, 2018 at 11:33:35AM +0800, Ming Lei wrote:
> It is pointed that bio_rewind_iter() is one very bad API[1]:
>
> 1) bio size may not be restored after rewinding
>
> 2) it causes some bogus change, such as 5151842b9d8732 (block: reset
> bi_iter.bi_done after splitting bio)
>
> 3) rewi
On 9/4/18 9:33 PM, Ming Lei wrote:
> It is pointed that bio_rewind_iter() is one very bad API[1]:
>
> 1) bio size may not be restored after rewinding
>
> 2) it causes some bogus change, such as 5151842b9d8732 (block: reset
> bi_iter.bi_done after splitting bio)
>
> 3) rewinding really makes thin
> + bio->bi_status = bio_integrity_process(bio, &bip->bio_iter,
> bi->profile->verify_fn);
Please split the overly long line.
Otherwise this looks fine:
Reviewed-by: Christoph Hellwig
Thanks for doing this, Ming
On Wed, Sep 05, 2018 at 11:33:35AM +0800, Ming Lei wrote:
> It is pointed that bio_rewind_iter() is one very bad API[1]:
>
> 1) bio size may not be restored after rewinding
>
> 2) it causes some bogus change, such as 5151842b9d8732 (block: reset
> bi_iter.bi_done afte
It is pointed that bio_rewind_iter() is one very bad API[1]:
1) bio size may not be restored after rewinding
2) it causes some bogus change, such as 5151842b9d8732 (block: reset
bi_iter.bi_done after splitting bio)
3) rewinding really makes things complicated wrt. bio splitting
4) unnecessary u
