Re: [PATCH] cdrom: information leak in cdrom_ioctl_media_changed()

2018-04-25 Thread Scott Bauer
On Wed, Apr 18, 2018 at 12:51:31PM +0300, Dan Carpenter wrote: > This cast is wrong. "cdi->capacity" is an int and "arg" is an unsigned > long. The way the check is written now, if one of the high 32 bits is > set then we could read outside the info->slots[] array. > > This bug is pretty old and

Re: [PATCH] cdrom: information leak in cdrom_ioctl_media_changed()

2018-04-18 Thread Jens Axboe
On 4/18/18 3:51 AM, Dan Carpenter wrote: > This cast is wrong. "cdi->capacity" is an int and "arg" is an unsigned > long. The way the check is written now, if one of the high 32 bits is > set then we could read outside the info->slots[] array. > > This bug is pretty old and it predates git. Tha

Re: [PATCH] cdrom: information leak in cdrom_ioctl_media_changed()

2018-04-18 Thread Christoph Hellwig
On Wed, Apr 18, 2018 at 12:51:31PM +0300, Dan Carpenter wrote: > This cast is wrong. "cdi->capacity" is an int and "arg" is an unsigned > long. The way the check is written now, if one of the high 32 bits is > set then we could read outside the info->slots[] array. > > This bug is pretty old and

[PATCH] cdrom: information leak in cdrom_ioctl_media_changed()

2018-04-18 Thread Dan Carpenter
This cast is wrong. "cdi->capacity" is an int and "arg" is an unsigned long. The way the check is written now, if one of the high 32 bits is set then we could read outside the info->slots[] array. This bug is pretty old and it predates git. Cc: sta...@vger.kernel.org Signed-off-by: Dan Carpente