Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Jens Axboe
On 6/4/18 10:40 AM, kvi...@gmail.com wrote: > From: Kevin Vigor > > Existing dev_dbg messages sometimes identify request using request > pointer, sometimes using nbd_cmd pointer. This makes it hard to > follow request flow. Consistently use request pointer instead. Applied, with the SOB added.

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Jens Axboe
On 6/5/18 8:30 AM, Josef Bacik wrote: > On Tue, Jun 05, 2018 at 08:23:06AM -0600, Jens Axboe wrote: >> On 6/4/18 10:40 AM, kvi...@gmail.com wrote: >>> From: Kevin Vigor >>> >>> Existing dev_dbg messages sometimes identify request using request >>> pointer, sometimes using nbd_cmd pointer. This mak

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Josef Bacik
On Tue, Jun 05, 2018 at 08:23:06AM -0600, Jens Axboe wrote: > On 6/4/18 10:40 AM, kvi...@gmail.com wrote: > > From: Kevin Vigor > > > > Existing dev_dbg messages sometimes identify request using request > > pointer, sometimes using nbd_cmd pointer. This makes it hard to > > follow request flow. C

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Jens Axboe
On 6/4/18 10:40 AM, kvi...@gmail.com wrote: > From: Kevin Vigor > > Existing dev_dbg messages sometimes identify request using request > pointer, sometimes using nbd_cmd pointer. This makes it hard to > follow request flow. Consistently use request pointer instead. You're missing the Signed-off-

Re: [PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-05 Thread Josef Bacik
On Mon, Jun 04, 2018 at 10:40:12AM -0600, kvi...@gmail.com wrote: > From: Kevin Vigor > > Existing dev_dbg messages sometimes identify request using request > pointer, sometimes using nbd_cmd pointer. This makes it hard to > follow request flow. Consistently use request pointer instead. Reviewed

[PATCH] nbd: Consistently use request pointer in debug messages.

2018-06-04 Thread kvigor
From: Kevin Vigor Existing dev_dbg messages sometimes identify request using request pointer, sometimes using nbd_cmd pointer. This makes it hard to follow request flow. Consistently use request pointer instead. --- drivers/block/nbd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletion