Re: [PATCH] nbd: clear DISCONNECT_REQUESTED flag once disconnection occurs.

2018-05-30 Thread Jens Axboe
On 5/30/18 10:45 AM, kvi...@gmail.com wrote: > From: Kevin Vigor > > When a userspace client requests a NBD device be disconnected, the > DISCONNECT_REQUESTED flag is set. While this flag is set, the driver > will not inform userspace when a connection is closed. > > Unfortunately the flag was

Re: [PATCH] nbd: clear DISCONNECT_REQUESTED flag once disconnection occurs.

2018-05-30 Thread Josef Bacik
On Wed, May 30, 2018 at 10:45:11AM -0600, kvi...@gmail.com wrote: > From: Kevin Vigor > > When a userspace client requests a NBD device be disconnected, the > DISCONNECT_REQUESTED flag is set. While this flag is set, the driver > will not inform userspace when a connection is closed. > >

[PATCH] nbd: clear DISCONNECT_REQUESTED flag once disconnection occurs.

2018-05-30 Thread kvigor
From: Kevin Vigor When a userspace client requests a NBD device be disconnected, the DISCONNECT_REQUESTED flag is set. While this flag is set, the driver will not inform userspace when a connection is closed. Unfortunately the flag was never cleared, so once a disconnect was requested the

Re: [PATCH] nbd: clear DISCONNECT_REQUESTED flag once disconnection occurs.

2018-05-30 Thread Jens Axboe
On 5/29/18 5:09 PM, kvi...@gmail.com wrote: > @@ -937,7 +946,7 @@ static int nbd_reconnect_socket(struct nbd_device *nbd, > unsigned long arg) > queue_work(recv_workqueue, >work); > > atomic_inc(>live_connections); > - wake_up(>conn_wait); > +

[PATCH] nbd: clear DISCONNECT_REQUESTED flag once disconnection occurs.

2018-05-29 Thread kvigor
From: Kevin Vigor When a userspace client requests a NBD device be disconnected, the DISCONNECT_REQUESTED flag is set. While this flag is set, the driver will not inform userspace when a connection is closed. Unfortunately the flag was never cleared, so once a disconnect was requested the