Re: [PATCH] null_blk: add 'requeue' fault attribute

2018-02-28 Thread Omar Sandoval
On Wed, Feb 28, 2018 at 08:28:25AM -0700, Jens Axboe wrote: > On 2/28/18 1:51 AM, Omar Sandoval wrote: > > On Tue, Feb 27, 2018 at 03:34:53PM -0700, Jens Axboe wrote: > >> Similarly to the support we have for testing/faking timeouts for > >> null_blk, this adds support for triggering a requeue

Re: [PATCH] null_blk: add 'requeue' fault attribute

2018-02-28 Thread Omar Sandoval
On Wed, Feb 28, 2018 at 09:15:37AM -0700, Jens Axboe wrote: > On 2/28/18 9:14 AM, Omar Sandoval wrote: > > On Wed, Feb 28, 2018 at 08:28:25AM -0700, Jens Axboe wrote: > >> On 2/28/18 1:51 AM, Omar Sandoval wrote: > >>> On Tue, Feb 27, 2018 at 03:34:53PM -0700, Jens Axboe wrote: > Similarly to

Re: [PATCH] null_blk: add 'requeue' fault attribute

2018-02-28 Thread Jens Axboe
On 2/28/18 9:14 AM, Omar Sandoval wrote: > On Wed, Feb 28, 2018 at 08:28:25AM -0700, Jens Axboe wrote: >> On 2/28/18 1:51 AM, Omar Sandoval wrote: >>> On Tue, Feb 27, 2018 at 03:34:53PM -0700, Jens Axboe wrote: Similarly to the support we have for testing/faking timeouts for null_blk,

Re: [PATCH] null_blk: add 'requeue' fault attribute

2018-02-28 Thread Jens Axboe
On 2/28/18 1:51 AM, Omar Sandoval wrote: > On Tue, Feb 27, 2018 at 03:34:53PM -0700, Jens Axboe wrote: >> Similarly to the support we have for testing/faking timeouts for >> null_blk, this adds support for triggering a requeue condition. >> Considering the issues around restart we've been seeing,

Re: [PATCH] null_blk: add 'requeue' fault attribute

2018-02-28 Thread Omar Sandoval
On Tue, Feb 27, 2018 at 03:34:53PM -0700, Jens Axboe wrote: > Similarly to the support we have for testing/faking timeouts for > null_blk, this adds support for triggering a requeue condition. > Considering the issues around restart we've been seeing, this should be > a useful addition to the

Re: [PATCH] null_blk: add 'requeue' fault attribute

2018-02-27 Thread Bart Van Assche
On Tue, 2018-02-27 at 15:34 -0700, Jens Axboe wrote: > Similarly to the support we have for testing/faking timeouts for > null_blk, this adds support for triggering a requeue condition. > Considering the issues around restart we've been seeing, this should be > a useful addition to the testing

[PATCH] null_blk: add 'requeue' fault attribute

2018-02-27 Thread Jens Axboe
Similarly to the support we have for testing/faking timeouts for null_blk, this adds support for triggering a requeue condition. Considering the issues around restart we've been seeing, this should be a useful addition to the testing arsenal to ensure that we are handling requeue conditions