Re: [PATCH] opal: Use empty structure when not defined

2017-02-16 Thread Scott Bauer
On Thu, Feb 16, 2017 at 12:07:08PM -0800, Christoph Hellwig wrote: > On Thu, Feb 16, 2017 at 11:45:29AM -0700, Scott Bauer wrote: > > > + if (check_opal_support(dev) < 0) { > > > pr_warn("Opal is not supported on this device\n"); > > > - opal_dev->initialized = true; > > > +

Re: [PATCH] opal: Use empty structure when not defined

2017-02-16 Thread Scott Bauer
On Wed, Feb 15, 2017 at 11:58:12PM -0800, Christoph Hellwig wrote: > I'd rather prefer to make the structure separately allocated as > discussed before. Scott, can you test the patch below? I'm not near > my devices I could test on. > > --- > From b2cda0c7ec5c0ec66582655751838f519cfa1706 Mon

Re: [PATCH] opal: Use empty structure when not defined

2017-02-16 Thread Scott Bauer
On Thu, Feb 16, 2017 at 10:37:55AM -0700, Scott Bauer wrote: > On Thu, Feb 16, 2017 at 10:18:59AM -0700, Jon Derrick wrote: > > It looks good to me at first glance but I can't apply it. What tree are > > you on? > > > > On 02/16/2017 12:58 AM, Christoph Hellwig wrote: > > > I'd rather prefer to

Re: [PATCH] opal: Use empty structure when not defined

2017-02-16 Thread Scott Bauer
On Thu, Feb 16, 2017 at 10:18:59AM -0700, Jon Derrick wrote: > It looks good to me at first glance but I can't apply it. What tree are > you on? > > On 02/16/2017 12:58 AM, Christoph Hellwig wrote: > > I'd rather prefer to make the structure separately allocated as > > discussed before. Scott,

Re: [PATCH] opal: Use empty structure when not defined

2017-02-16 Thread Jon Derrick
It looks good to me at first glance but I can't apply it. What tree are you on? On 02/16/2017 12:58 AM, Christoph Hellwig wrote: > I'd rather prefer to make the structure separately allocated as > discussed before. Scott, can you test the patch below? I'm not near > my devices I could test on.

Re: [PATCH] opal: Use empty structure when not defined

2017-02-15 Thread Christoph Hellwig
I'd rather prefer to make the structure separately allocated as discussed before. Scott, can you test the patch below? I'm not near my devices I could test on. --- >From b2cda0c7ec5c0ec66582655751838f519cfa1706 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Thu, 16 Feb

Re: [PATCH] opal: Use empty structure when not defined

2017-02-15 Thread Scott Bauer
On Wed, Feb 15, 2017 at 07:16:27PM -0500, Keith Busch wrote: > No need to use space if it can't be used. This reduces the size of struct > nvme_ctrl by a little over 4k when CONFIG_BLK_SED_OPAL is not set. > > Signed-off-by: Keith Busch > --- > include/linux/sed-opal.h |