Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-27 Thread Jens Axboe
On 04/27/2017 09:20 AM, Christoph Hellwig wrote: > On Thu, Apr 27, 2017 at 06:49:43AM -0700, Jens Axboe wrote: >> Thanks Ming, I've added that patch and your patch to initialize the cmd >> at runtime. > > I really think this is the wrong fix, and doing these sort of band-aids > just will lead to

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-27 Thread Christoph Hellwig
On Thu, Apr 27, 2017 at 06:49:43AM -0700, Jens Axboe wrote: > Thanks Ming, I've added that patch and your patch to initialize the cmd > at runtime. I really think this is the wrong fix, and doing these sort of band-aids just will lead to further problems done the road.

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-27 Thread Jens Axboe
On 04/26/2017 08:14 PM, Ming Lei wrote: > On Wed, Apr 26, 2017 at 11:22:43AM -0700, Jens Axboe wrote: >> On 04/26/2017 11:15 AM, Jens Axboe wrote: >>> On 04/26/2017 03:48 AM, Ming Lei wrote: Hi Christoph, On Thu, Apr 20, 2017 at 04:30:42PM +0800, Ming Lei wrote: > Hi Christoph,

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-27 Thread Christoph Hellwig
On Wed, Apr 26, 2017 at 06:48:43PM +0800, Ming Lei wrote: > Looks there are some choices for this issue: > > 1) if internal ops uses independent tag space > - we need to clean up the mtip32xx driver > > 2) if internal ops shares tag space with normal request > - export blk_mq_get_driver_tag()

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-26 Thread Ming Lei
On Wed, Apr 26, 2017 at 11:22:43AM -0700, Jens Axboe wrote: > On 04/26/2017 11:15 AM, Jens Axboe wrote: > > On 04/26/2017 03:48 AM, Ming Lei wrote: > >> Hi Christoph, > >> > >> On Thu, Apr 20, 2017 at 04:30:42PM +0800, Ming Lei wrote: > >>> Hi Christoph, > >>> > >>> On Wed, Apr 19, 2017 at

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-26 Thread Jens Axboe
On 04/26/2017 11:15 AM, Jens Axboe wrote: > On 04/26/2017 03:48 AM, Ming Lei wrote: >> Hi Christoph, >> >> On Thu, Apr 20, 2017 at 04:30:42PM +0800, Ming Lei wrote: >>> Hi Christoph, >>> >>> On Wed, Apr 19, 2017 at 09:54:08PM -0700, Christoph Hellwig wrote: On Thu, Apr 20, 2017 at 09:03:47AM

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-26 Thread Jens Axboe
On 04/26/2017 03:48 AM, Ming Lei wrote: > Hi Christoph, > > On Thu, Apr 20, 2017 at 04:30:42PM +0800, Ming Lei wrote: >> Hi Christoph, >> >> On Wed, Apr 19, 2017 at 09:54:08PM -0700, Christoph Hellwig wrote: >>> On Thu, Apr 20, 2017 at 09:03:47AM +0800, Ming Lei wrote: If we don't need to

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-26 Thread Ming Lei
Hi Christoph, On Thu, Apr 20, 2017 at 04:30:42PM +0800, Ming Lei wrote: > Hi Christoph, > > On Wed, Apr 19, 2017 at 09:54:08PM -0700, Christoph Hellwig wrote: > > On Thu, Apr 20, 2017 at 09:03:47AM +0800, Ming Lei wrote: > > > If we don't need to reserve tag for internal command, I am happy > >

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-20 Thread Jens Axboe
On 04/19/2017 10:54 PM, Christoph Hellwig wrote: > On Thu, Apr 20, 2017 at 09:03:47AM +0800, Ming Lei wrote: >> If we don't need to reserve tag for internal command, I am happy >> to fix it in the interim. However, the mtip32xx driver has to >> ask blk-mq to reserve the tag zero for internal

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-20 Thread Ming Lei
Hi Christoph, On Wed, Apr 19, 2017 at 09:54:08PM -0700, Christoph Hellwig wrote: > On Thu, Apr 20, 2017 at 09:03:47AM +0800, Ming Lei wrote: > > If we don't need to reserve tag for internal command, I am happy > > to fix it in the interim. However, the mtip32xx driver has to > > ask blk-mq to

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-19 Thread Christoph Hellwig
On Thu, Apr 20, 2017 at 09:03:47AM +0800, Ming Lei wrote: > If we don't need to reserve tag for internal command, I am happy > to fix it in the interim. However, the mtip32xx driver has to > ask blk-mq to reserve the tag zero for internal command. Then > if we can't allow the driver to use that

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-19 Thread Ming Lei
On Wed, Apr 19, 2017 at 06:55:30PM -0600, Jens Axboe wrote: > On 04/19/2017 06:44 PM, Ming Lei wrote: > > On Wed, Apr 19, 2017 at 02:17:45PM -0600, Jens Axboe wrote: > >> On 04/15/2017 06:38 AM, Ming Lei wrote: > >>> The 1st patch enhances BLK_MQ_F_NO_SCHED so that we can't change/ > >>> show

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-19 Thread Jens Axboe
On 04/19/2017 06:44 PM, Ming Lei wrote: > On Wed, Apr 19, 2017 at 02:17:45PM -0600, Jens Axboe wrote: >> On 04/15/2017 06:38 AM, Ming Lei wrote: >>> The 1st patch enhances BLK_MQ_F_NO_SCHED so that we can't change/ >>> show available io schedulers on devices which don't support io >>> scheduler.

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-19 Thread Ming Lei
On Wed, Apr 19, 2017 at 02:17:45PM -0600, Jens Axboe wrote: > On 04/15/2017 06:38 AM, Ming Lei wrote: > > The 1st patch enhances BLK_MQ_F_NO_SCHED so that we can't change/ > > show available io schedulers on devices which don't support io > > scheduler. > > > > The 2nd patch passes

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-19 Thread Jens Axboe
On 04/15/2017 06:38 AM, Ming Lei wrote: > The 1st patch enhances BLK_MQ_F_NO_SCHED so that we can't change/ > show available io schedulers on devices which don't support io > scheduler. > > The 2nd patch passes BLK_MQ_F_NO_SCHED for avoiding one regression > on mtip32xx, which is introduced by

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-18 Thread Ming Lei
On Mon, Apr 17, 2017 at 10:30:46AM -0700, Omar Sandoval wrote: > On Mon, Apr 17, 2017 at 12:03:53AM +0800, Ming Lei wrote: > > On Sat, Apr 15, 2017 at 08:38:21PM +0800, Ming Lei wrote: > > > The 1st patch enhances BLK_MQ_F_NO_SCHED so that we can't change/ > > > show available io schedulers on

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-17 Thread Omar Sandoval
On Mon, Apr 17, 2017 at 12:03:53AM +0800, Ming Lei wrote: > On Sat, Apr 15, 2017 at 08:38:21PM +0800, Ming Lei wrote: > > The 1st patch enhances BLK_MQ_F_NO_SCHED so that we can't change/ > > show available io schedulers on devices which don't support io > > scheduler. > > > > The 2nd patch

Re: [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-16 Thread Ming Lei
On Sat, Apr 15, 2017 at 08:38:21PM +0800, Ming Lei wrote: > The 1st patch enhances BLK_MQ_F_NO_SCHED so that we can't change/ > show available io schedulers on devices which don't support io > scheduler. > > The 2nd patch passes BLK_MQ_F_NO_SCHED for avoiding one regression > on mtip32xx, which

[PATCH 0/4] blk-mq-sched: allow to use hw tag for sched

2017-04-15 Thread Ming Lei
The 1st patch enhances BLK_MQ_F_NO_SCHED so that we can't change/ show available io schedulers on devices which don't support io scheduler. The 2nd patch passes BLK_MQ_F_NO_SCHED for avoiding one regression on mtip32xx, which is introduced by blk-mq io scheduler. The last two patches introduce