Re: [PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout

2018-05-28 Thread Ming Lei
On Mon, May 28, 2018 at 01:44:25PM +0200, Christoph Hellwig wrote: > On Thu, May 24, 2018 at 12:45:15PM +0800, Ming Lei wrote: > > This change should have been done after '[PATCH 13/14] blk-mq: Remove > > generation seqeunce', otherwise the timed-out request won't be completed > > by

Re: [PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout

2018-05-28 Thread Christoph Hellwig
On Wed, May 23, 2018 at 03:27:35PM +0200, Hannes Reinecke wrote: > Is there a way of _testing_ this patch? Use the error injection framework Johannes wrote? Use blktests (but make sure you have a fixed version of test 011). > It looks pretty dodgy, just replacing BLK_EH_HANDLED with >

Re: [PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout

2018-05-28 Thread Christoph Hellwig
On Thu, May 24, 2018 at 12:45:15PM +0800, Ming Lei wrote: > This change should have been done after '[PATCH 13/14] blk-mq: Remove > generation seqeunce', otherwise the timed-out request won't be completed > by nvme_cancel_request() at all because we always marked this request as > 'COMPLETE'

Re: [PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout

2018-05-23 Thread Ming Lei
On Wed, May 23, 2018 at 02:19:30PM +0200, Christoph Hellwig wrote: > NVMe always completes the request before returning from ->timeout, either > by polling for it, or by disabling the controller. Return BLK_EH_DONE so > that the block layer doesn't even try to complete it again. > >

Re: [PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout

2018-05-23 Thread Hannes Reinecke
On 05/23/2018 02:19 PM, Christoph Hellwig wrote: NVMe always completes the request before returning from ->timeout, either by polling for it, or by disabling the controller. Return BLK_EH_DONE so that the block layer doesn't even try to complete it again. Signed-off-by: Christoph Hellwig

Re: [PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout

2018-05-23 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham

[PATCH 03/14] nvme: return BLK_EH_DONE from ->timeout

2018-05-23 Thread Christoph Hellwig
NVMe always completes the request before returning from ->timeout, either by polling for it, or by disabling the controller. Return BLK_EH_DONE so that the block layer doesn't even try to complete it again. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/pci.c| 14