Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints

On 2017/7/11 上午11:48, Coly Li wrote: > On 2017/7/6 下午11:24, Christoph Hellwig wrote: >> On Thu, Jul 06, 2017 at 03:35:48PM +0800, Coly Li wrote: >>> Then gfs2 breaks the above rule ? in gfs2_metapath_ra() and >>> gfs2_dir_readahead(), only REQ_META is used in submit_bh(). It seems an >>> extra

Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints

On 2017/7/6 下午11:24, Christoph Hellwig wrote: > On Thu, Jul 06, 2017 at 03:35:48PM +0800, Coly Li wrote: >> Then gfs2 breaks the above rule ? in gfs2_metapath_ra() and >> gfs2_dir_readahead(), only REQ_META is used in submit_bh(). It seems an >> extra REQ_PRIO should be there. > > Or maybe not.

Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints

On 2017/7/6 上午2:48, Christoph Hellwig wrote: > REQ_META should be purely a hint for blktrace, please don't use it > in the I/O path - that's what REQ_PRIO is for. > -- > To unsubscribe from this list: send the line "unsubscribe linux-bcache" in > the body of a message to majord...@vger.kernel.org

Re: [PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints

On 2017/7/4 上午6:51, bca...@lists.ewheeler.net wrote: > From: Eric Wheeler > > Flag for bypass if the IO is for read-ahead or background, unless the > read-ahead request is for metadata (eg, from gfs2). > Bypass if: > bio->bi_opf &

[PATCH 09/19 v2] bcache: update bio->bi_opf bypass/writeback REQ_ flag hints

From: Eric Wheeler Flag for bypass if the IO is for read-ahead or background, unless the read-ahead request is for metadata (eg, from gfs2). Bypass if: bio->bi_opf & (REQ_RAHEAD|REQ_BACKGROUND) && !(bio->bi_opf & REQ_META)) Writeback if: