Re: [PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

2016-08-13 Thread Sergei Shtylyov
Hello. On 8/12/2016 5:36 PM, Tom Yan wrote: diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index be9c76c..4e2d8e7 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -1204,14 +1204,26 @@ static int ata_scsi_dev_config(struct scsi_device *sdev, i

Re: [PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

2016-08-12 Thread Tom Yan
On 12 August 2016 at 21:42, Sergei Shtylyov wrote: > On 08/12/2016 02:56 PM, tom.t...@gmail.com wrote: > >> From: Tom Yan >> >> Currently we use dev->max_sectors to set max_hw_sectors, which >> is actually supposed to be a host controller limit (that get set > > >Gets. > > Thanks, but I read

Re: [PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

2016-08-12 Thread Tom Yan
On 12 August 2016 at 19:56, wrote: > > Also note that ATA_HORKAGE_MAX_SEC_LBA48 is not supposed to work > automatically anyway, even when max_hw_sectors is as high as 65535, > since the effective max_sectors will be set by the SCSI disk driver. > I missed the fact that ATA_HORKAGE_MAX_SEC_LBA48 i

Re: [PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

2016-08-12 Thread Sergei Shtylyov
On 08/12/2016 02:56 PM, tom.t...@gmail.com wrote: From: Tom Yan Currently we use dev->max_sectors to set max_hw_sectors, which is actually supposed to be a host controller limit (that get set Gets. by the host controller driver like ahci, and if not it would be the fallback SCSI_DEFAULT

[PATCH 1/2] libata-scsi: use dev->max_sectors from libata-core appropriately

2016-08-12 Thread tom . ty89
From: Tom Yan Currently we use dev->max_sectors to set max_hw_sectors, which is actually supposed to be a host controller limit (that get set by the host controller driver like ahci, and if not it would be the fallback SCSI_DEFAULT_MAX_SECTORS). That means we have been doing the wrong thing. The