Re: [PATCH 1/2] nbd: don't requeue the same request twice.

2018-07-16 Thread Jens Axboe
On 7/16/18 10:11 AM, Josef Bacik wrote: > We can race with the snd timeout and the per-request timeout and end up > requeuing the same request twice. We can't use the send_complete > completion to tell if everything is ok because we hold the tx_lock > during send, so the timeout stuff will block w

[PATCH 1/2] nbd: don't requeue the same request twice.

2018-07-16 Thread Josef Bacik
We can race with the snd timeout and the per-request timeout and end up requeuing the same request twice. We can't use the send_complete completion to tell if everything is ok because we hold the tx_lock during send, so the timeout stuff will block waiting to mark the socket dead, and we could be