RE: [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues

2018-03-28 Thread Don Brace
.com>; qla2xxx- > upstr...@qlogic.com; linux-s...@vger.kernel.org > Subject: [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues > > EXTERNAL EMAIL > > > The PCI interrupt vectors intended to be associated with a queue may > not start at 0; a driver may alloc

Re: [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues

2018-03-27 Thread Jens Axboe
On 3/27/18 9:39 AM, Keith Busch wrote: > The PCI interrupt vectors intended to be associated with a queue may > not start at 0; a driver may allocate pre_vectors for special use. This > patch adds an offset parameter so blk-mq may find the intended affinity > mask and updates all drivers using

Re: [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues

2018-03-27 Thread Ming Lei
On Tue, Mar 27, 2018 at 09:39:06AM -0600, Keith Busch wrote: > The PCI interrupt vectors intended to be associated with a queue may > not start at 0; a driver may allocate pre_vectors for special use. This > patch adds an offset parameter so blk-mq may find the intended affinity > mask and updates

[PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues

2018-03-27 Thread Keith Busch
The PCI interrupt vectors intended to be associated with a queue may not start at 0; a driver may allocate pre_vectors for special use. This patch adds an offset parameter so blk-mq may find the intended affinity mask and updates all drivers using this API accordingly. Cc: Don Brace

Re: [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues

2018-03-27 Thread Christoph Hellwig
On Fri, Mar 23, 2018 at 04:19:21PM -0600, Keith Busch wrote: > The PCI interrupt vectors intended to be associated with a queue may > not start at 0. This patch adds an offset parameter so blk-mq may find > the intended affinity mask. The default value is 0 so existing drivers > that don't care

Re: [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues

2018-03-26 Thread Keith Busch
On Mon, Mar 26, 2018 at 09:50:38AM +0800, Ming Lei wrote: > > Given no many callers of blk_mq_pci_map_queues(), I suggest to add the > parameter of 'offset' to this API directly, then people may keep the > '.pre_vectors' stuff in mind, and avoid to misuse it. Yeah, I think I have to agree. I

Re: [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues

2018-03-26 Thread Keith Busch
On Sat, Mar 24, 2018 at 09:55:49PM +0800, jianchao.wang wrote: > Maybe we could provide a callback parameter for __blk_mq_pci_map_queues which > give the mapping from hctx queue num to device-relative interrupt vector > index. If a driver's mapping is so complicated as to require a special

Re: [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues

2018-03-25 Thread Ming Lei
On Fri, Mar 23, 2018 at 04:19:21PM -0600, Keith Busch wrote: > The PCI interrupt vectors intended to be associated with a queue may > not start at 0. This patch adds an offset parameter so blk-mq may find > the intended affinity mask. The default value is 0 so existing drivers > that don't care

Re: [PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues

2018-03-24 Thread jianchao.wang
Hi Keith Thanks for your time and patch for this. On 03/24/2018 06:19 AM, Keith Busch wrote: > The PCI interrupt vectors intended to be associated with a queue may > not start at 0. This patch adds an offset parameter so blk-mq may find > the intended affinity mask. The default value is 0 so

[PATCH 1/3] blk-mq: Allow PCI vector offset for mapping queues

2018-03-23 Thread Keith Busch
The PCI interrupt vectors intended to be associated with a queue may not start at 0. This patch adds an offset parameter so blk-mq may find the intended affinity mask. The default value is 0 so existing drivers that don't care about this parameter don't need to change. Signed-off-by: Keith Busch