On Fri, 28 Oct 2016, Christoph Hellwig wrote:
> [adding Chaitanya to Cc]
>
> On Fri, Oct 28, 2016 at 07:43:41AM -0400, Mikulas Patocka wrote:
> > We could detect if the REQ_OP_WRITE_SAME command contains all zeroes and
> > if it does, turn it into "Write Zeroes" or TRIM command (if the device
On Fri, 28 Oct 2016, Bart Van Assche wrote:
> On 10/28/2016 04:39 AM, Mikulas Patocka wrote:
> > On Wed, 26 Oct 2016, Bart Van Assche wrote:
> > > On 10/26/2016 02:46 PM, Mikulas Patocka wrote:
> > > > I think the proper thing would be to move "discard_zeroes_data" flag
> > > > into
> > > > the
On Wed, 26 Oct 2016, Christoph Hellwig wrote:
> On Wed, Oct 26, 2016 at 05:46:11PM -0400, Mikulas Patocka wrote:
> > I think the proper thing would be to move "discard_zeroes_data" flag into
> > the bio itself - there would be REQ_OP_DISCARD and REQ_OP_DISCARD_ZERO -
> > and if the device
On Wed, 26 Oct 2016, Bart Van Assche wrote:
> On 10/26/2016 02:46 PM, Mikulas Patocka wrote:
> > I don't like the idea of complicating the code by turning discards into
> > writes.
>
> That's not what my patch series does. The only writes added by my patch series
> are those for the
On 10/26/2016 02:46 PM, Mikulas Patocka wrote:
I don't like the idea of complicating the code by turning discards into
writes.
That's not what my patch series does. The only writes added by my patch
series are those for the non-aligned head and tail of the range passed
to
On Wed, Oct 26, 2016 at 05:46:11PM -0400, Mikulas Patocka wrote:
> I think the proper thing would be to move "discard_zeroes_data" flag into
> the bio itself - there would be REQ_OP_DISCARD and REQ_OP_DISCARD_ZERO -
> and if the device doesn't support REQ_OP_DISCARD_ZERO, it rejects the bio
>
On Wed, 26 Oct 2016, Bart Van Assche wrote:
> On 10/26/2016 01:26 PM, Mikulas Patocka wrote:
> > The brd driver refuses misaligned discard requests with an error. However,
> > this is suboptimal, misaligned requests could be handled by discarding a
> > part of the request that is aligned on a
On 10/26/2016 01:26 PM, Mikulas Patocka wrote:
The brd driver refuses misaligned discard requests with an error. However,
this is suboptimal, misaligned requests could be handled by discarding a
part of the request that is aligned on a page boundary. This patch changes
the code so that it
The brd driver refuses misaligned discard requests with an error. However,
this is suboptimal, misaligned requests could be handled by discarding a
part of the request that is aligned on a page boundary. This patch changes
the code so that it handles misaligned requests.
Signed-off-by: Mikulas
