Re: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs

2018-06-05 Thread Keith Busch
On Tue, Jun 05, 2018 at 06:47:33AM +0200, Christoph Hellwig wrote: > But let's assume we don't want to use the list due to this concern: > we'd still have to read the log page, as per the NVMe spec the only > think clearing a pending AEN is reading the associated log page. > We'd then need to still

Re: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs

2018-06-04 Thread Christoph Hellwig
On Mon, Jun 04, 2018 at 01:59:09PM -0600, Keith Busch wrote: > > Per section 5.2 we need to issue the corresponding log page to clear an > > AEN, so for a namespace data changed AEN we need to read the changed > > namespace list log. And once we read that log anyway we might as well > > use it to

Re: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs

2018-06-04 Thread Keith Busch
On Sat, May 26, 2018 at 12:27:34PM +0200, Christoph Hellwig wrote: > Per section 5.2 we need to issue the corresponding log page to clear an > AEN, so for a namespace data changed AEN we need to read the changed > namespace list log. And once we read that log anyway we might as well > use it to op

Re: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs

2018-05-28 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N

Re: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs

2018-05-26 Thread Christoph Hellwig
On Sat, May 26, 2018 at 12:05:02PM +, Popuri, Sriram wrote: > Reading the spec it looks like ns log is alternate approach: > > "Namespace Attribute Changed: The Identify Namespace data structure for one > or more namespaces, as well as the Namespace List returned when the Identify > command

RE: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs

2018-05-26 Thread Popuri, Sriram
y 26, 2018 3:58 PM To: linux-n...@lists.infradead.org Cc: Jens Axboe ; Keith Busch ; linux-block@vger.kernel.org; Sagi Grimberg ; Hannes Reinecke Subject: [PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs Per section 5.2 we need to issue the corresponding log page to clear an

[PATCH 13/14] nvme: use the changed namespaces list log to clear ns data changed AENs

2018-05-26 Thread Christoph Hellwig
Per section 5.2 we need to issue the corresponding log page to clear an AEN, so for a namespace data changed AEN we need to read the changed namespace list log. And once we read that log anyway we might as well use it to optimize the rescan. Signed-off-by: Christoph Hellwig --- drivers/nvme/hos