Re: [PATCH 18/19] bcache: silence static checker warning

2017-07-13 Thread Coly Li
On 2017/7/1 上午4:43, bca...@lists.ewheeler.net wrote: > From: Dan Carpenter > > In olden times, closure_return() used to have a hidden return built in. > We removed the hidden return but forgot to add a new return here. If > "c" were NULL we would oops on the next line,

[PATCH 18/19] bcache: silence static checker warning

2017-06-30 Thread bcache
From: Dan Carpenter In olden times, closure_return() used to have a hidden return built in. We removed the hidden return but forgot to add a new return here. If "c" were NULL we would oops on the next line, but fortunately "c" is never NULL. Let's just remove the if

[PATCH 18/19] bcache: silence static checker warning

2017-06-30 Thread Dan Carpenter
In olden times, closure_return() used to have a hidden return built in. We removed the hidden return but forgot to add a new return here. If "c" were NULL we would oops on the next line, but fortunately "c" is never NULL. Let's just remove the if statement. Signed-off-by: Dan Carpenter

[PATCH 18/19] bcache: silence static checker warning

2017-06-30 Thread Dan Carpenter
In olden times, closure_return() used to have a hidden return built in. We removed the hidden return but forgot to add a new return here. If "c" were NULL we would oops on the next line, but fortunately "c" is never NULL. Let's just remove the if statement. Signed-off-by: Dan Carpenter