Re: [PATCH 2/2] block/sed-opal: allocate struct opal_dev dynamically

2017-02-17 Thread Johannes Thumshirn
On 02/16/2017 09:10 PM, Christoph Hellwig wrote: > -enum opal_response_token { > - OPAL_DTA_TOKENID_BYTESTRING = 0xe0, > - OPAL_DTA_TOKENID_SINT = 0xe1, > - OPAL_DTA_TOKENID_UINT = 0xe2, > - OPAL_DTA_TOKENID_TOKEN = 0xe3, /* actual token is returned */ > -

Re: [PATCH 2/2] block/sed-opal: allocate struct opal_dev dynamically

2017-02-16 Thread Scott Bauer
On Thu, Feb 16, 2017 at 09:10:53PM +0100, Christoph Hellwig wrote: > Insted of bloating the containing structure with it all the time this > allocates struct opal_dev dynamically. Additionally this allows moving > the definition of struct opal_dev into sed-opal.c. For this a new > private data

[PATCH 2/2] block/sed-opal: allocate struct opal_dev dynamically

2017-02-16 Thread Christoph Hellwig
Insted of bloating the containing structure with it all the time this allocates struct opal_dev dynamically. Additionally this allows moving the definition of struct opal_dev into sed-opal.c. For this a new private data field is added to it that is passed to the send/receive callback. After