Re: [PATCH 4/5] nvme: implement multipath access to nvme subsystems

2017-11-09 Thread Christoph Hellwig
On Thu, Nov 09, 2017 at 04:44:32PM +0100, Hannes Reinecke wrote: > - We don't have the topology information in sysfs; We have all the topology information in sysfs, but you seem to look for the wrong thing. > while the namespace > device has the 'slaves' and 'holders' directories, they remain emp

Re: [PATCH 4/5] nvme: implement multipath access to nvme subsystems

2017-11-09 Thread Hannes Reinecke
On 11/02/2017 07:30 PM, Christoph Hellwig wrote: > This patch adds native multipath support to the nvme driver. For each > namespace we create only single block device node, which can be used > to access that namespace through any of the controllers that refer to it. > The gendisk for each control

Re: [PATCH 4/5] nvme: implement multipath access to nvme subsystems

2017-11-09 Thread Christoph Hellwig
On Wed, Nov 08, 2017 at 12:18:32PM +0100, Hannes Reinecke wrote: > On 11/08/2017 09:54 AM, Christoph Hellwig wrote: > > Can I get a review for this one? The only changes vs the previously > > reviewed versions is that we don't use the multipath code at all for > > subsystems that aren't multiporte

Re: [PATCH 4/5] nvme: implement multipath access to nvme subsystems

2017-11-08 Thread Hannes Reinecke
On 11/08/2017 09:54 AM, Christoph Hellwig wrote: > Can I get a review for this one? The only changes vs the previously > reviewed versions is that we don't use the multipath code at all for > subsystems that aren't multiported, and that there is an explicit > opt-out at compile and module load tim

Re: [PATCH 4/5] nvme: implement multipath access to nvme subsystems

2017-11-08 Thread Christoph Hellwig
Can I get a review for this one? The only changes vs the previously reviewed versions is that we don't use the multipath code at all for subsystems that aren't multiported, and that there is an explicit opt-out at compile and module load time, so it shouldn't be that hard to review for those who r

Re: [PATCH 4/5] nvme: implement multipath access to nvme subsystems

2017-11-06 Thread Mike Snitzer
On Thu, Nov 02 2017 at 2:30pm -0400, Christoph Hellwig wrote: > This patch adds native multipath support to the nvme driver. For each > namespace we create only single block device node, which can be used > to access that namespace through any of the controllers that refer to it. > The gendisk

[PATCH 4/5] nvme: implement multipath access to nvme subsystems

2017-11-02 Thread Christoph Hellwig
This patch adds native multipath support to the nvme driver. For each namespace we create only single block device node, which can be used to access that namespace through any of the controllers that refer to it. The gendisk for each controllers path to the name space still exists inside the kerne