Re: [PATCH V14 13/24] mmc: block: Add blk-mq support

2017-11-28 Thread Ulf Hansson
[...] > + > +enum mmc_issued mmc_blk_mq_issue_rq(struct mmc_queue *mq, struct request > *req) > +{ > + struct mmc_blk_data *md = mq->blkdata; > + struct mmc_card *card = md->queue.card; > + struct mmc_host *host = card->host; > + int ret; >>

Re: [PATCH V14 13/24] mmc: block: Add blk-mq support

2017-11-27 Thread Adrian Hunter
On 27/11/17 13:23, Ulf Hansson wrote: > On 27 November 2017 at 11:20, Adrian Hunter wrote: >> On 24/11/17 12:12, Ulf Hansson wrote: >>> [...] >>> +/* Single sector read during recovery */ +static void mmc_blk_ss_read(struct mmc_queue *mq, struct request *req) >>> >>> Nitpick: I think mmc

Re: [PATCH V14 13/24] mmc: block: Add blk-mq support

2017-11-27 Thread Ulf Hansson
+ Jens, Paolo [...] >>> +static int mmc_blk_mq_issue_rw_rq(struct mmc_queue *mq, >>> + struct request *req) >>> +{ >>> + struct mmc_queue_req *mqrq = req_to_mmc_queue_req(req); >>> + struct mmc_host *host = mq->card->host; >>> + struct request *pr

Re: [PATCH V14 13/24] mmc: block: Add blk-mq support

2017-11-27 Thread Ulf Hansson
On 27 November 2017 at 11:20, Adrian Hunter wrote: > On 24/11/17 12:12, Ulf Hansson wrote: >> [...] >> >>> +/* Single sector read during recovery */ >>> +static void mmc_blk_ss_read(struct mmc_queue *mq, struct request *req) >> >> Nitpick: I think mmc_blk_read_single() would be better as it is a m

Re: [PATCH V14 13/24] mmc: block: Add blk-mq support

2017-11-27 Thread Adrian Hunter
On 24/11/17 12:12, Ulf Hansson wrote: > [...] > >> +/* Single sector read during recovery */ >> +static void mmc_blk_ss_read(struct mmc_queue *mq, struct request *req) > > Nitpick: I think mmc_blk_read_single() would be better as it is a more > clear name. Would you mind changing it? > >> +{ >>

Re: [PATCH V14 13/24] mmc: block: Add blk-mq support

2017-11-24 Thread Ulf Hansson
[...] > +/* Single sector read during recovery */ > +static void mmc_blk_ss_read(struct mmc_queue *mq, struct request *req) Nitpick: I think mmc_blk_read_single() would be better as it is a more clear name. Would you mind changing it? > +{ > + struct mmc_queue_req *mqrq = req_to_mmc_queue_

[PATCH V14 13/24] mmc: block: Add blk-mq support

2017-11-21 Thread Adrian Hunter
Define and use a blk-mq queue. Discards and flushes are processed synchronously, but reads and writes asynchronously. In order to support slow DMA unmapping, DMA unmapping is not done until after the next request is started. That means the request is not completed until then. If there is no next re