Re: [PATCH V2 0/3] block: make sure discard/writesame bio is aligned with logical block size

2018-11-09 Thread Jens Axboe
On 11/6/18 5:55 PM, Ming Lei wrote: > On Tue, Nov 06, 2018 at 04:48:13PM +, Rui Salvaterra wrote: >> On Mon, 5 Nov 2018 at 03:41, Ming Lei wrote: >>> >>> V2 addresses Christoph's comment by introducing bio_allowed_max_sectors(). >>> >>> Ping... >>> >>> Thanks, >>> Ming >> >> Hi, Ming, >> >>

Re: [PATCH V2 0/3] block: make sure discard/writesame bio is aligned with logical block size

2018-11-06 Thread Ming Lei
On Tue, Nov 06, 2018 at 04:48:13PM +, Rui Salvaterra wrote: > On Mon, 5 Nov 2018 at 03:41, Ming Lei wrote: > > > > V2 addresses Christoph's comment by introducing bio_allowed_max_sectors(). > > > > Ping... > > > > Thanks, > > Ming > > Hi, Ming, > > Sorry for the delay. I tested your V2

Re: [PATCH V2 0/3] block: make sure discard/writesame bio is aligned with logical block size

2018-11-06 Thread Rui Salvaterra
On Mon, 5 Nov 2018 at 03:41, Ming Lei wrote: > > V2 addresses Christoph's comment by introducing bio_allowed_max_sectors(). > > Ping... > > Thanks, > Ming Hi, Ming, Sorry for the delay. I tested your V2 against Linux 4.20-rc1 and everything seems fine. FWIW, V2 is also Tested-by: Rui

Re: [PATCH V2 0/3] block: make sure discard/writesame bio is aligned with logical block size

2018-11-04 Thread Ming Lei
On Mon, Oct 29, 2018 at 08:57:16PM +0800, Ming Lei wrote: > Hi, > > The 1st & 3rd patch fixes bio size alignment issue. > > The 2nd patch cleans up __blkdev_issue_discard() a bit. > > V2: > - introduce helper of bio_allowed_max_sectors() > - add commit log for patch 2 > > > Ming

[PATCH V2 0/3] block: make sure discard/writesame bio is aligned with logical block size

2018-10-29 Thread Ming Lei
Hi, The 1st & 3rd patch fixes bio size alignment issue. The 2nd patch cleans up __blkdev_issue_discard() a bit. V2: - introduce helper of bio_allowed_max_sectors() - add commit log for patch 2 Ming Lei (3): block: make sure discard bio is aligned with logical block size