Re: [PATCH V4 07/15] blk-throttle: make throtl_slice tunable

2016-11-23 Thread Tejun Heo
Hello, On Tue, Nov 22, 2016 at 03:18:24PM -0800, Shaohua Li wrote: > Hmm, it's not a real 'time slice'. The name is a bit confusion. Maybe rename > it > to 'throtl_interval' or 'throtl_sampling_time'? not sure. bandwidth and iops > are always in terms of a time interval we measure them. We can't

Re: [PATCH V4 07/15] blk-throttle: make throtl_slice tunable

2016-11-22 Thread Shaohua Li
On Tue, Nov 22, 2016 at 04:27:15PM -0500, Tejun Heo wrote: > Hello, > > On Mon, Nov 14, 2016 at 02:22:14PM -0800, Shaohua Li wrote: > > throtl_slice is important for blk-throttling. A lot of stuffes depend on > > it, for example, throughput measurement. It has 100ms default value, > > which is not

Re: [PATCH V4 07/15] blk-throttle: make throtl_slice tunable

2016-11-22 Thread Tejun Heo
Hello, On Mon, Nov 14, 2016 at 02:22:14PM -0800, Shaohua Li wrote: > throtl_slice is important for blk-throttling. A lot of stuffes depend on > it, for example, throughput measurement. It has 100ms default value, > which is not appropriate for all disks. For example, for SSD we might > use a small

[PATCH V4 07/15] blk-throttle: make throtl_slice tunable

2016-11-14 Thread Shaohua Li
throtl_slice is important for blk-throttling. A lot of stuffes depend on it, for example, throughput measurement. It has 100ms default value, which is not appropriate for all disks. For example, for SSD we might use a smaller value to make the throughput smoother. This patch makes it tunable. Sign