Re: [PATCH v1 02/14] block: introduce bio_remove_last_page()

2017-02-28 Thread Ming Lei
On Sun, Feb 26, 2017 at 2:23 AM, Christoph Hellwig wrote: > On Fri, Feb 24, 2017 at 11:42:39PM +0800, Ming Lei wrote: >> MD need this helper to remove the last added page, so introduce >> it. > > If MD really has a valid use case for this it should open code the > operation.

Re: [PATCH v1 02/14] block: introduce bio_remove_last_page()

2017-02-25 Thread Christoph Hellwig
On Fri, Feb 24, 2017 at 11:42:39PM +0800, Ming Lei wrote: > MD need this helper to remove the last added page, so introduce > it. If MD really has a valid use case for this it should open code the operation. The semantics look deeply fishy to me.

[PATCH v1 02/14] block: introduce bio_remove_last_page()

2017-02-24 Thread Ming Lei
MD need this helper to remove the last added page, so introduce it. Signed-off-by: Ming Lei --- block/bio.c | 23 +++ include/linux/bio.h | 1 + 2 files changed, 24 insertions(+) diff --git a/block/bio.c b/block/bio.c index