Re: [PATCH v2 2/2] blk-mq: Add a polling specific stats function

2017-04-07 Thread Jens Axboe
On 04/07/2017 06:11 AM, Stephen Bates wrote: > On 2017-04-05, 7:14 PM, "Jens Axboe" wrote: > >> Why not just have 8 buckets, and make it: >> >> bucket = ddir + ilog2(bytes) - 9; >> >> and cap it at MAX_BUCKET (8) and put all those above into the top >> bucket. > > Thanks.

Re: [PATCH v2 2/2] blk-mq: Add a polling specific stats function

2017-04-07 Thread Stephen Bates
On 2017-04-05, 7:14 PM, "Jens Axboe" wrote: > Why not just have 8 buckets, and make it: > > bucket = ddir + ilog2(bytes) - 9; > > and cap it at MAX_BUCKET (8) and put all those above into the top > bucket. Thanks. However, that equation does not differentiate between

Re: [PATCH v2 2/2] blk-mq: Add a polling specific stats function

2017-04-05 Thread Jens Axboe
On 04/05/2017 11:39 AM, sba...@raithlin.com wrote: > @@ -42,6 +42,33 @@ static LIST_HEAD(all_q_list); > static void blk_mq_poll_stats_start(struct request_queue *q); > static void blk_mq_poll_stats_fn(struct blk_stat_callback *cb); > > +static int blk_mq_poll_stats_bkt(const struct request