Re: [PATCH v4] virtio_blk: Fix an SG_IO regression

2017-10-28 Thread Bart Van Assche
On Fri, 2017-10-27 at 08:24 -0600, Jens Axboe wrote: > On 10/27/2017 12:39 AM, Christoph Hellwig wrote: > > How about only defininig the initialize_rq method and implementation > > if CONFIG_VIRTIO_BLK_SCSI is set? > > I did that while merging it. Thanks Jens and Christoph! Bart.

Re: [PATCH v4] virtio_blk: Fix an SG_IO regression

2017-10-27 Thread Jens Axboe
On 10/27/2017 12:39 AM, Christoph Hellwig wrote: > On Thu, Oct 26, 2017 at 12:10:15PM +0200, Bart Van Assche wrote: >> Avoid that submitting an SG_IO ioctl triggers a kernel oops that >> is preceded by: >> >> usercopy: kernel memory overwrite attempt detected to (null) () (6 >> bytes) >> kernel

Re: [PATCH v4] virtio_blk: Fix an SG_IO regression

2017-10-27 Thread Christoph Hellwig
On Thu, Oct 26, 2017 at 12:10:15PM +0200, Bart Van Assche wrote: > Avoid that submitting an SG_IO ioctl triggers a kernel oops that > is preceded by: > > usercopy: kernel memory overwrite attempt detected to (null) () (6 > bytes) > kernel BUG at mm/usercopy.c:72! > > Reported-by: Dann Frazier

[PATCH v4] virtio_blk: Fix an SG_IO regression

2017-10-26 Thread Bart Van Assche
Avoid that submitting an SG_IO ioctl triggers a kernel oops that is preceded by: usercopy: kernel memory overwrite attempt detected to (null) () (6 bytes) kernel BUG at mm/usercopy.c:72! Reported-by: Dann Frazier Fixes: commit ca18d6f769d2 ("block: Make most